You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/08 09:48:56 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #21390: Fix check data source state(#21378)
FlyingZC opened a new pull request, #21390:
URL: https://github.com/apache/shardingsphere/pull/21390
Fixes #21378.
Changes proposed in this pull request:
- Fix check data source state
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have passed maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC commented on pull request #21390: Fix check data source state(#21378)
Posted by GitBox <gi...@apache.org>.
FlyingZC commented on PR #21390:
URL: https://github.com/apache/shardingsphere/pull/21390#issuecomment-1272292692
<img width="914" alt="image" src="https://user-images.githubusercontent.com/19788130/194704078-773f7701-32f8-4814-a63c-9c2a7bad29a1.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #21390: Fix check data source state(#21378)
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #21390:
URL: https://github.com/apache/shardingsphere/pull/21390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21390: Fix check data source state(#21378)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21390:
URL: https://github.com/apache/shardingsphere/pull/21390#issuecomment-1272299685
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21390?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21390](https://codecov.io/gh/apache/shardingsphere/pull/21390?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f35fda) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e2f2e4491006d7e57615b1926913921e9414b9df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2f2e44) will **increase** coverage by `0.00%`.
> The diff coverage is `59.09%`.
```diff
@@ Coverage Diff @@
## master #21390 +/- ##
=========================================
Coverage 61.58% 61.58%
Complexity 2507 2507
=========================================
Files 4089 4089
Lines 56609 56605 -4
Branches 7487 7487
=========================================
- Hits 34860 34858 -2
+ Misses 18832 18831 -1
+ Partials 2917 2916 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/standalone/StandaloneContextManagerBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/21390/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL3N0YW5kYWxvbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL3N0YW5kYWxvbmUvU3RhbmRhbG9uZUNvbnRleHRNYW5hZ2VyQnVpbGRlci5qYXZh) | `81.25% <ø> (-0.57%)` | :arrow_down: |
| [...here/proxy/version/ShardingSphereProxyVersion.java](https://codecov.io/gh/apache/shardingsphere/pull/21390/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS92ZXJzaW9uL1NoYXJkaW5nU3BoZXJlUHJveHlWZXJzaW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gsphere/mode/metadata/MetaDataContextsFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/21390/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL01ldGFEYXRhQ29udGV4dHNGYWN0b3J5LmphdmE=) | `79.48% <58.82%> (-15.97%)` | :arrow_down: |
| [...nfra/metadata/database/ShardingSphereDatabase.java](https://codecov.io/gh/apache/shardingsphere/pull/21390/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9TaGFyZGluZ1NwaGVyZURhdGFiYXNlLmphdmE=) | `83.33% <100.00%> (+0.47%)` | :arrow_up: |
| [.../manager/cluster/ClusterContextManagerBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/21390/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL2NsdXN0ZXIvQ2x1c3RlckNvbnRleHRNYW5hZ2VyQnVpbGRlci5qYXZh) | `82.75% <100.00%> (+13.19%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org