You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2023/10/17 18:57:11 UTC
Review Request 74680: RANGER-4478: Incorrect trie updates when processing deltas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74680/
-----------------------------------------------------------
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, madhan, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-4478
https://issues.apache.org/jira/browse/RANGER-4478
Repository: ranger
Description
-------
When policy-delta feature is enabled, updates to Ranger policies result in only the updates (deltas) being delivered to the plugin embedded in the service. In a long-running service and in the face of frequent ranger updates, sometimes, the internal structures of the policy-engine are not correctly updated. This may result in evaluation of incomplete set of policies when computing result of authorization request.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java 2f725036d
Diff: https://reviews.apache.org/r/74680/diff/1/
Testing
-------
Passes all unit tests.
Tested with a long running cluster with a client updating Hive policies frequenty and Hive queries issued from a beeline client.
Thanks,
Abhay Kulkarni
Re: Review Request 74680: RANGER-4478: Incorrect trie updates when processing deltas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74680/#review225869
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 17, 2023, 6:59 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74680/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2023, 6:59 p.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, madhan, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4478
> https://issues.apache.org/jira/browse/RANGER-4478
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When a plugin is configured to receive policy-deltas, policy engine processing of the deltas to update its resource tries can result some policies to be not included in the trie.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java 2f725036d
>
>
> Diff: https://reviews.apache.org/r/74680/diff/1/
>
>
> Testing
> -------
>
> Passes all unit tests.
>
> Tested with a long running cluster with a client updating Hive policies frequenty and Hive queries issued from a beeline client.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 74680: RANGER-4478: Incorrect trie updates when processing deltas
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74680/
-----------------------------------------------------------
(Updated Oct. 17, 2023, 6:59 p.m.)
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, madhan, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Updated description
Bugs: RANGER-4478
https://issues.apache.org/jira/browse/RANGER-4478
Repository: ranger
Description (updated)
-------
When a plugin is configured to receive policy-deltas, policy engine processing of the deltas to update its resource tries can result some policies to be not included in the trie.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java 2f725036d
Diff: https://reviews.apache.org/r/74680/diff/1/
Testing
-------
Passes all unit tests.
Tested with a long running cluster with a client updating Hive policies frequenty and Hive queries issued from a beeline client.
Thanks,
Abhay Kulkarni