You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/10/04 13:53:27 UTC

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous 

Hello Jean-Daniel Cryans, Adar Dembo, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/11579

to review the following change.


Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................

KUDU-1592 Make warnings about FBM more ominous

The documentation warned about scalability issues with file block
manager, but it was rather lightly worded and so was the warning message
of a hole punch test failure.

This commit removes the actual flag necessary to enable FBM from the
hole punching tests' warning to force users look it up in the
documentation instead of blindly applying it, adds a note about it being
unsuitable for production use to the flag's description and expands the
warning in the troubleshooting section.

Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
---
M docs/troubleshooting.adoc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager.cc
3 files changed, 32 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/11579/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11579/2/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11579/2/docs/troubleshooting.adoc@85
PS2, Line 85: perfor
> Nit: I'd drop this; we don't know that for a fact, and as much as we'd like
Done


http://gerrit.cloudera.org:8080/#/c/11579/2/docs/troubleshooting.adoc@86
PS2, Line 86: l amo
> Nit: a small
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 17:54:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11579/2/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11579/2/docs/troubleshooting.adoc@85
PS2, Line 85: severe
Nit: I'd drop this; we don't know that for a fact, and as much as we'd like people to stop using the FBM, we should only use the arguments we truly believe in.


http://gerrit.cloudera.org:8080/#/c/11579/2/docs/troubleshooting.adoc@86
PS2, Line 86: small
Nit: a small



-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 17:43:02 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11579

to look at the new patch set (#2).

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................

KUDU-1592 Make warnings about FBM more ominous

The documentation warned about scalability issues with file block
manager, but it was rather lightly worded and so was the warning message
of a hole punch test failure.

This commit removes the actual flag necessary to enable FBM from the
hole punching tests' warning to force users look it up in the
documentation instead of blindly applying it, adds a note about it being
unsuitable for production use to the flag's description and expands the
warning in the troubleshooting section.

Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
---
M docs/troubleshooting.adoc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager.cc
3 files changed, 28 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/11579/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc@85
PS1, Line 85: This results in a very large number of file descriptors that
            : the tablet server needs to open even with small amounts of data, which is a
            : limited resource and the tablet servers can easily exhaust it with file block manager.
This isn't true; the FileCache will recycle file descriptors on an LRU basis in order to keep the total open fd count below a certain threshold.

That doesn't detract from the larger argument (that it's not as performant) though.


http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc@89
PS1, Line 89: One more reason why file block manager should be avoided is that it's
            : *impossible to switch between block managers* without wiping and reinitializing
            : the tablet servers.
Combine this into the previous paragraph.


http://gerrit.cloudera.org:8080/#/c/11579/1/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:

http://gerrit.cloudera.org:8080/#/c/11579/1/src/kudu/fs/fs_manager.cc@70
PS1, Line 70: File 
Nit: "The file block manager..."



-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 04 Oct 2018 18:21:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc@85
PS1, Line 85: This can cause severe performance issues compared to the log
            : block manager even with small amount of data and it's *impossible to switch
            : between block managers* without wiping and reinitializing the tablet servers.
> This isn't true; the FileCache will recycle file descriptors on an LRU basi
Done


http://gerrit.cloudera.org:8080/#/c/11579/1/docs/troubleshooting.adoc@89
PS1, Line 89: 
            : [[disk_issues]]
            : === Already present
> Combine this into the previous paragraph.
Done


http://gerrit.cloudera.org:8080/#/c/11579/1/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:

http://gerrit.cloudera.org:8080/#/c/11579/1/src/kudu/fs/fs_manager.cc@70
PS1, Line 70: The f
> Nit: "The file block manager..."
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 09:53:46 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11579

to look at the new patch set (#3).

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................

KUDU-1592 Make warnings about FBM more ominous

The documentation warned about scalability issues with file block
manager, but it was rather lightly worded and so was the warning message
of a hole punch test failure.

This commit removes the actual flag necessary to enable FBM from the
hole punching tests' warning to force users look it up in the
documentation instead of blindly applying it, adds a note about it being
unsuitable for production use to the flag's description and expands the
warning in the troubleshooting section.

Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
---
M docs/troubleshooting.adoc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager.cc
3 files changed, 28 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/11579/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 3: Verified+1

another flaky test failure


-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 18:40:08 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 17:55:35 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 2: Verified+1

verifying manually, Jenkins failed on an irrelevant flaky test failure


-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 10:14:12 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11579/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11579/3//COMMIT_MSG@14
PS3, Line 14: to force users look it up in the
            : documentation instead of blindly applying it
Brilliant!



-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 18:01:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................

KUDU-1592 Make warnings about FBM more ominous

The documentation warned about scalability issues with file block
manager, but it was rather lightly worded and so was the warning message
of a hole punch test failure.

This commit removes the actual flag necessary to enable FBM from the
hole punching tests' warning to force users look it up in the
documentation instead of blindly applying it, adds a note about it being
unsuitable for production use to the flag's description and expands the
warning in the troubleshooting section.

Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Reviewed-on: http://gerrit.cloudera.org:8080/11579
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Attila Bukor <ab...@apache.org>
---
M docs/troubleshooting.adoc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/fs_manager.cc
3 files changed, 28 insertions(+), 9 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Andrew Wong: Looks good to me, approved
  Attila Bukor: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] KUDU-1592 Make warnings about FBM more ominous

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11579 )

Change subject: KUDU-1592 Make warnings about FBM more ominous
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review+2
> 
> (1 comment)

thanks :)


-- 
To view, visit http://gerrit.cloudera.org:8080/11579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15adf42dd7e6376a85cdb178ad460f239a4f87a1
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 05 Oct 2018 18:40:15 +0000
Gerrit-HasComments: No