You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Mickael Maison <mi...@gmail.com> on 2018/04/25 08:51:38 UTC
[VOTE] KIP-282: Add the listener name to the authentication context
Hi,
There has been no objections in the DISCUSS thread so I'd like to
start a vote on KIP-282:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-282%3A+Add+the+listener+name+to+the+authentication+context
Thanks
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Mickael Maison <mi...@gmail.com>.
Bumping as it still needs a few votes =)
On Wed, Apr 25, 2018 at 8:24 PM, Mickael Maison
<mi...@gmail.com> wrote:
> I've updated the KIP to simply expose the String value instead of the
> full ListenerName object.
>
> On Wed, Apr 25, 2018 at 8:10 PM, Mickael Maison
> <mi...@gmail.com> wrote:
>> Thanks for the heads up Ismael. In that case, I also think it makes
>> sense to just use the String representation.
>>
>> I'll update the KIP to reflect that change
>>
>> On Wed, Apr 25, 2018 at 7:25 PM, Rajini Sivaram <ra...@gmail.com> wrote:
>>> Sorry, I hadn't noticed that it was using `ListenerName`. I think we should
>>> return just a String.
>>>
>>> On Wed, Apr 25, 2018 at 7:02 PM, Ismael Juma <is...@gmail.com> wrote:
>>>
>>>> ListenerName is in an internal package, so we would have to move it before
>>>> exposing it in a public API.
>>>>
>>>> Ismael
>>>>
>>>> On Wed, 25 Apr 2018, 01:52 Mickael Maison, <mi...@gmail.com>
>>>> wrote:
>>>>
>>>> > Hi,
>>>> >
>>>> > There has been no objections in the DISCUSS thread so I'd like to
>>>> > start a vote on KIP-282:
>>>> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>>> > 282%3A+Add+the+listener+name+to+the+authentication+context
>>>> >
>>>> > Thanks
>>>> >
>>>>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Mickael Maison <mi...@gmail.com>.
I've updated the KIP to simply expose the String value instead of the
full ListenerName object.
On Wed, Apr 25, 2018 at 8:10 PM, Mickael Maison
<mi...@gmail.com> wrote:
> Thanks for the heads up Ismael. In that case, I also think it makes
> sense to just use the String representation.
>
> I'll update the KIP to reflect that change
>
> On Wed, Apr 25, 2018 at 7:25 PM, Rajini Sivaram <ra...@gmail.com> wrote:
>> Sorry, I hadn't noticed that it was using `ListenerName`. I think we should
>> return just a String.
>>
>> On Wed, Apr 25, 2018 at 7:02 PM, Ismael Juma <is...@gmail.com> wrote:
>>
>>> ListenerName is in an internal package, so we would have to move it before
>>> exposing it in a public API.
>>>
>>> Ismael
>>>
>>> On Wed, 25 Apr 2018, 01:52 Mickael Maison, <mi...@gmail.com>
>>> wrote:
>>>
>>> > Hi,
>>> >
>>> > There has been no objections in the DISCUSS thread so I'd like to
>>> > start a vote on KIP-282:
>>> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>> > 282%3A+Add+the+listener+name+to+the+authentication+context
>>> >
>>> > Thanks
>>> >
>>>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Mickael Maison <mi...@gmail.com>.
Thanks for the heads up Ismael. In that case, I also think it makes
sense to just use the String representation.
I'll update the KIP to reflect that change
On Wed, Apr 25, 2018 at 7:25 PM, Rajini Sivaram <ra...@gmail.com> wrote:
> Sorry, I hadn't noticed that it was using `ListenerName`. I think we should
> return just a String.
>
> On Wed, Apr 25, 2018 at 7:02 PM, Ismael Juma <is...@gmail.com> wrote:
>
>> ListenerName is in an internal package, so we would have to move it before
>> exposing it in a public API.
>>
>> Ismael
>>
>> On Wed, 25 Apr 2018, 01:52 Mickael Maison, <mi...@gmail.com>
>> wrote:
>>
>> > Hi,
>> >
>> > There has been no objections in the DISCUSS thread so I'd like to
>> > start a vote on KIP-282:
>> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> > 282%3A+Add+the+listener+name+to+the+authentication+context
>> >
>> > Thanks
>> >
>>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Rajini Sivaram <ra...@gmail.com>.
Sorry, I hadn't noticed that it was using `ListenerName`. I think we should
return just a String.
On Wed, Apr 25, 2018 at 7:02 PM, Ismael Juma <is...@gmail.com> wrote:
> ListenerName is in an internal package, so we would have to move it before
> exposing it in a public API.
>
> Ismael
>
> On Wed, 25 Apr 2018, 01:52 Mickael Maison, <mi...@gmail.com>
> wrote:
>
> > Hi,
> >
> > There has been no objections in the DISCUSS thread so I'd like to
> > start a vote on KIP-282:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 282%3A+Add+the+listener+name+to+the+authentication+context
> >
> > Thanks
> >
>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Ismael Juma <is...@gmail.com>.
ListenerName is in an internal package, so we would have to move it before
exposing it in a public API.
Ismael
On Wed, 25 Apr 2018, 01:52 Mickael Maison, <mi...@gmail.com> wrote:
> Hi,
>
> There has been no objections in the DISCUSS thread so I'd like to
> start a vote on KIP-282:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 282%3A+Add+the+listener+name+to+the+authentication+context
>
> Thanks
>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Manikumar <ma...@gmail.com>.
+1 (non-binding)
On Wed, Apr 25, 2018 at 9:05 PM, Ted Yu <yu...@gmail.com> wrote:
> +1
>
> On Wed, Apr 25, 2018 at 8:33 AM, Rajini Sivaram <ra...@gmail.com>
> wrote:
>
> > Hi Mickael,
> >
> > Thanks for the KIP.
> >
> > +1 (binding)
> >
> > On Wed, Apr 25, 2018 at 9:51 AM, Mickael Maison <
> mickael.maison@gmail.com>
> > wrote:
> >
> > > Hi,
> > >
> > > There has been no objections in the DISCUSS thread so I'd like to
> > > start a vote on KIP-282:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 282%3A+Add+the+listener+name+to+the+authentication+context
> > >
> > > Thanks
> > >
> >
>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Ted Yu <yu...@gmail.com>.
+1
On Wed, Apr 25, 2018 at 8:33 AM, Rajini Sivaram <ra...@gmail.com>
wrote:
> Hi Mickael,
>
> Thanks for the KIP.
>
> +1 (binding)
>
> On Wed, Apr 25, 2018 at 9:51 AM, Mickael Maison <mi...@gmail.com>
> wrote:
>
> > Hi,
> >
> > There has been no objections in the DISCUSS thread so I'd like to
> > start a vote on KIP-282:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 282%3A+Add+the+listener+name+to+the+authentication+context
> >
> > Thanks
> >
>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Rajini Sivaram <ra...@gmail.com>.
Hi Mickael,
Thanks for the KIP.
+1 (binding)
On Wed, Apr 25, 2018 at 9:51 AM, Mickael Maison <mi...@gmail.com>
wrote:
> Hi,
>
> There has been no objections in the DISCUSS thread so I'd like to
> start a vote on KIP-282:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 282%3A+Add+the+listener+name+to+the+authentication+context
>
> Thanks
>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Jun Rao <ju...@confluent.io>.
Hi, Mickael,
Thanks for the KIP. +1
Jun
On Wed, Apr 25, 2018 at 1:51 AM, Mickael Maison <mi...@gmail.com>
wrote:
> Hi,
>
> There has been no objections in the DISCUSS thread so I'd like to
> start a vote on KIP-282:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 282%3A+Add+the+listener+name+to+the+authentication+context
>
> Thanks
>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Mickael Maison <mi...@gmail.com>.
Thanks to everyone who voted and reviewed the KIP.
The vote has passed with 3 binding votes (Rajini, Jun and Ismael) and
2 non-binding votes (Ted and Manikumar).
Link to the PR: https://github.com/apache/kafka/pull/4829
On Tue, May 15, 2018 at 7:05 PM, Ismael Juma <is...@juma.me.uk> wrote:
> Thanks for the KIP, +1 (binding).
>
> Ismael
>
> On Wed, Apr 25, 2018 at 1:52 AM Mickael Maison <mi...@gmail.com>
> wrote:
>
>> Hi,
>>
>> There has been no objections in the DISCUSS thread so I'd like to
>> start a vote on KIP-282:
>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-282%3A+Add+the+listener+name+to+the+authentication+context
>>
>> Thanks
>>
Re: [VOTE] KIP-282: Add the listener name to the authentication context
Posted by Ismael Juma <is...@juma.me.uk>.
Thanks for the KIP, +1 (binding).
Ismael
On Wed, Apr 25, 2018 at 1:52 AM Mickael Maison <mi...@gmail.com>
wrote:
> Hi,
>
> There has been no objections in the DISCUSS thread so I'd like to
> start a vote on KIP-282:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-282%3A+Add+the+listener+name+to+the+authentication+context
>
> Thanks
>