[GitHub] flink pull request #5242: [hotfix] Fix typos

[greghogan <gi...@git.apache.org>]

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/5242

    [hotfix] Fix typos

    ## What is the purpose of the change
    
    Fix typos from the IntelliJ "Typos" inspection. I have tried to preserve British vs American English spellings. IntelliJ is adamant about reordering imports in two files.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 20180103a_fix_typos

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5242
    
----
commit 916169ae5e5ce0c7298a6cae2e6f1ccfd8a07cfe
Author: Greg Hogan <co...@...>
Date:   2018-01-03T19:19:58Z

    [hotfix] Fix typos
    
    Fix typos from the IntelliJ "Typos" inspection.

----


---

[GitHub] flink issue #5242: [hotfix] Fix typos

[StephanEwen <gi...@git.apache.org>]

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5242
  
    Wow, this is pretty good! Thanks a lot!
    
    Addressing Fabian's comment and merging this. Want that merged very soon to avoid future merge conflicts...


---

[GitHub] flink pull request #5242: [hotfix] Fix typos

[fhueske <gi...@git.apache.org>]

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5242#discussion_r159829159
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala ---
    @@ -153,7 +153,7 @@ class CsvTableSource private (
       override def projectFields(fields: Array[Int]): CsvTableSource = {
     
         val selectedFields = if (fields.isEmpty) Array(0) else fields
    -//    val selectedFiels = fields
    +//    val selectedFields = fields
    --- End diff --
    
    This line can be removed.


---

[GitHub] flink pull request #5242: [hotfix] Fix typos

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5242


---