You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Marat Abrarov (Jira)" <ji...@apache.org> on 2020/10/20 10:03:00 UTC
[jira] [Comment Edited] (MEAR-288) SNAPSHOT dependency JAR having
timestamp name in WAR is not removed from WAR when skinnyWars option is
turned on
[ https://issues.apache.org/jira/browse/MEAR-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216169#comment-17216169 ]
Marat Abrarov edited comment on MEAR-288 at 10/20/20, 10:02 AM:
----------------------------------------------------------------
[~elharo], could you please close this bug as resolved because [pull request #23|https://github.com/apache/maven-ear-plugin/pull/23] was merged?
was (Author: abrarovm):
Can we close this bug as resolved because [pull request #23|https://github.com/apache/maven-ear-plugin/pull/23] was merged?
> SNAPSHOT dependency JAR having timestamp name in WAR is not removed from WAR when skinnyWars option is turned on
> ----------------------------------------------------------------------------------------------------------------
>
> Key: MEAR-288
> URL: https://issues.apache.org/jira/browse/MEAR-288
> Project: Maven Ear Plugin
> Issue Type: Bug
> Affects Versions: 3.1.0
> Reporter: Marat Abrarov
> Priority: Major
>
> SNAPSHOT dependency JAR having *timestamp* name in WAR is not removed from WAR when skinnyWars option is turned on.
> Refer to [skinny-wars-timestamp|https://github.com/apache/maven-ear-plugin/tree/maven-ear-plugin-3.1.0/src/it/skinny-wars-timestamp] integration test. When this test is executed it generates this WAR archive:
> {noformat}
> target/it/skinny-wars-timestamp/war-module/target/war-module-1.0.war
> ├───META-INF/
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───war-module/
> │ ├───pom.properties
> │ └───pom.xml
> └───WEB-INF/
> ├───web.xml
> ├───classes/
> └───lib/
> ├───commons-lang-2.5.jar
> └───jar-sample-one-1.0-20150825.210557-91.jar
> {noformat}
> and this EAR archive:
> {noformat}
> target/it/skinny-wars-timestamp/ear-module/target/ear-module-1.0.ear
> ├───commons-lang-commons-lang-2.5.jar
> ├───eartest-jar-sample-one-1.0-20150825.210557-91.jar
> │
> ├───META-INF/
> │ ├───application.xml
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───ear-module/
> │ ├───pom.properties
> │ └───pom.xml
> │
> └───org.apache.maven.its.ear.skinnywars-war-module-1.0.war
> ├───META-INF/
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───war-module/
> │ ├───pom.properties
> │ └───pom.xml
> │
> └───WEB-INF/
> ├───web.xml
> ├───classes/
> └───lib/
> └───jar-sample-one-1.0-20150825.210557-91.jar
> {noformat}
> while expected EAR archive is:
> {noformat}
> target/it/skinny-wars-timestamp/ear-module/target/ear-module-1.0.ear
> ├───commons-lang-commons-lang-2.5.jar
> ├───eartest-jar-sample-one-1.0-20150825.210557-91.jar
> │
> ├───META-INF/
> │ ├───application.xml
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───ear-module/
> │ ├───pom.properties
> │ └───pom.xml
> │
> └───org.apache.maven.its.ear.skinnywars-war-module-1.0.war
> ├───META-INF/
> │ ├───MANIFEST.MF
> │ └───maven/
> │ └───org.apache.maven.its.ear.skinnywars/
> │ └───war-module/
> │ ├───pom.properties
> │ └───pom.xml
> │
> └───WEB-INF/
> ├───web.xml
> ├───classes/
> └───lib/
> {noformat}
> i.e. target/it/skinny-wars-timestamp/ear-module/target/ear-module-1.0.ear/org.apache.maven.its.ear.skinnywars-war-module-1.0.war/WEB-INF/lib/jar-sample-one-1.0-20150825.210557-91.jar file should not exist (because of skinnyWars option turned on).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)