You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "plchldr (via GitHub)" <gi...@apache.org> on 2023/07/28 08:07:00 UTC
[GitHub] [camel] plchldr opened a new pull request, #10880: support more MLLP charsets
plchldr opened a new pull request, #10880:
URL: https://github.com/apache/camel/pull/10880
# Description
We recently received HL7 messages with `MSH-18` = `UNICODE UTF-8`
This is currently not supported in camel-mllp, which we only became aware of because of a user complaint regarding garbled characters. This is because [`MllpCharsetHelper` falls back to a default charset](https://github.com/apache/camel/blob/camel-3.21.0/components/camel-mllp/src/main/java/org/apache/camel/component/mllp/MllpCharsetHelper.java#L56-L58) (ISO-8859-2).
We expected `MSH-18` to be respected if set, but the current behavior might just be according to spec ...
Anyway; for our use case this simple change suffices.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
(this generated some unrelated changes that I could push, but would rather not)
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #10880: support more MLLP charsets
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #10880:
URL: https://github.com/apache/camel/pull/10880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10880: support more MLLP charsets
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10880:
URL: https://github.com/apache/camel/pull/10880#issuecomment-1655788415
https://issues.apache.org/jira/browse/CAMEL-19677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10880: support more MLLP charsets
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10880:
URL: https://github.com/apache/camel/pull/10880#issuecomment-1655409433
Would be good to backport this to 3.x LTS branches also. And we appreciate a JIRA ticket about this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10880: support more MLLP charsets
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10880:
URL: https://github.com/apache/camel/pull/10880#issuecomment-1655238672
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org