[GitHub] [thrift] srnwk commented on pull request #2543: workaround MSVC compiler bug

[GitBox <gi...@apache.org>]

srnwk commented on pull request #2543:
URL: https://github.com/apache/thrift/pull/2543#issuecomment-1064654182


   > I use it with VS2022 and had not experienced any issues.
   > 
   > Could you enlighten us what the problem is exactly? "fails fails to build" is a bit too vague (and grammatically questionable :-))
   
   Here's a minimal repro https://godbolt.org/z/b76n9oaKv
   ```
   <source>(9,102): error C2064: term does not evaluate to a function taking 0 arguments
           std::string const old_file_contents(static_cast<std::ostringstream const&>(std::ostringstream() << old_file.rdbuf()).str());
                                                                                                        ^
   ```
   
   When compiling with /std:c++20 (or C++17 with /permissive-), this blows up with the above error.
   (There's no reason I can tell why it should, clang and GCC agree).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org