[GitHub] [geode] albertogpz edited a comment on pull request #7114: GEODE-9642: skip RedundancyRecovery for colocated regions, if colocat…

[GitBox <gi...@apache.org>]

albertogpz edited a comment on pull request #7114:
URL: https://github.com/apache/geode/pull/7114#issuecomment-984283948


   > > > @albertogpz Did your concerns get addressed?
   > > 
   > > 
   > > I think the modified tests still need to check that recovery was started at least in one of the servers.
   > 
   > As far as I understand the tests, any time `checkIfRecoveryExecuted()` is called, it's implicitly checking that recovery was started, because if recovery is never started on any servers, then the calls to `recoveryStarted.await()` will time out and `recoveryExecuted` will not be set to true.
   
   The problem is that the tests are not checking that recovery is started at least in one server. They are only checking for every server that if recovery is started, then it will be done in a reasonable time.
   But it could be that recovery is not started in any server and the tests will pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org