[GitHub] mccheah commented on a change in pull request #25: Add the encryption metadata field to the DataFile schema

[GitBox <gi...@apache.org>]

mccheah commented on a change in pull request #25: Add the encryption metadata field to the DataFile schema
URL: https://github.com/apache/incubator-iceberg/pull/25#discussion_r239653374
 
 

 ##########
 File path: api/src/main/java/com/netflix/iceberg/encryption/EncryptionTypes.java
 ##########
 @@ -0,0 +1,50 @@
+package com.netflix.iceberg.encryption;
+
+import com.netflix.iceberg.types.Types;
+
+import java.nio.ByteBuffer;
+
+public class EncryptionTypes {
 
 Review comment:
   Yup I think the github ticket is becoming a little unwieldy for this scale of a design. I'd be ok with starting a design document for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services