You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/10 09:40:35 UTC

[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #529: Restrict project related operations to admins/ domain admins and project owners

Pearl1594 opened a new pull request #529:
URL: https://github.com/apache/cloudstack-primate/pull/529


   Addresses: https://github.com/apache/cloudstack-primate/issues/485


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #529: Restrict project related operations to admins/ domain admins and project owners

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #529:
URL: https://github.com/apache/cloudstack-primate/pull/529#discussion_r452740928



##########
File path: src/config/section/project.js
##########
@@ -82,15 +82,20 @@ export default {
       icon: 'edit',
       label: 'label.edit.project.details',
       dataView: true,
-      args: ['displaytext']
+      args: ['displaytext'],
+      show: (record, store) => {
+        return record.account === store.userInfo.account || ['Admin', 'DomainAdmin'].includes(store.userInfo.roletype)

Review comment:
       Note to self; this may change with Pearl's project roles-feature.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #529: Restrict project related operations to admins/ domain admins and project owners

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #529:
URL: https://github.com/apache/cloudstack-primate/pull/529#issuecomment-656586625


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #529: Restrict project related operations to admins/ domain admins and project owners

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #529:
URL: https://github.com/apache/cloudstack-primate/pull/529


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #529: Restrict project related operations to admins/ domain admins and project owners

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #529:
URL: https://github.com/apache/cloudstack-primate/pull/529#issuecomment-656589838


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/529 (JID-2271)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #529: Restrict project related operations to admins/ domain admins and project owners

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #529:
URL: https://github.com/apache/cloudstack-primate/pull/529#issuecomment-656586307


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org