[GitHub] [incubator-seatunnel] zhuangchong commented on pull request #2662: [hotfix][e2e] refactor jupiter,add junit-jupiter-api

[GitBox <gi...@apache.org>]

zhuangchong commented on PR #2662:
URL: https://github.com/apache/incubator-seatunnel/pull/2662#issuecomment-1240180914

   My suggestion is to introduce junit-bom for dependency management and remove `junit-jupiter-engine` and `junit-jupiter-params` with the following changes:
   
   add:
   
   ```
               <dependency>
                   <groupId>org.junit</groupId>
                   <artifactId>junit-bom</artifactId>
                   <version>${junit.version}</version>
                   <type>pom</type>
                   <scope>import</scope>
               </dependency>
   ```
   remote:
   ```
   <dependency>
                   <groupId>org.junit.jupiter</groupId>
                   <artifactId>junit-jupiter-engine</artifactId>
                   <version>${junit.version}</version>
                   <scope>test</scope>
               </dependency>
   
               <dependency>
                   <groupId>org.junit.jupiter</groupId>
                   <artifactId>junit-jupiter-params</artifactId>
                   <version>${junit.version}</version>
                   <scope>test</scope>
               </dependency>
   ```
   update:
   ```
   <dependencies>
   ...
    <dependency>
               <groupId>org.junit.jupiter</groupId>
               <artifactId>junit-jupiter-engine</artifactId>
               <scope>test</scope>
           </dependency>
           <dependency>
               <groupId>org.junit.jupiter</groupId>
               <artifactId>junit-jupiter-params</artifactId>
               <scope>test</scope>
           </dependency>
   
       </dependencies>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org