You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "matrei (via GitHub)" <gi...@apache.org> on 2026/08/10 11:08:42 UTC
[PR] Fix `@ManagedEntity` compilation for Grails domains [grails-core]
matrei opened a new pull request, #16121:
URL: https://github.com/apache/grails-core/pull/16121
Fixes compilation failures when `@ManagedEntity` is used on a Grails domain class.
`HibernateEntityTransformation` and `GormEntityTransformation` were sharing the same `ClassNode` metadata key for their “transformation applied” markers.
The Hibernate transformation overwrote GORM’s marker after invoking it, allowing GORM transformation to run again. Under Grails 8/Groovy 5, the second pass could fail in `DirtyCheckingTransformer` while collecting getter/setter pairs.
Hibernate transformations now use a dedicated metadata marker, preserving GORM’s marker and making the transformations idempotent.
Changes
- Added a Hibernate-specific transformation marker for Hibernate 5.
- Added the same fix for Hibernate 7.
- Verified compilation of the grails-test-examples-app1 reproducer.
- Verified the Hibernate 5 and Hibernate 7 transformation tests.
Closes #16107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `@ManagedEntity` compilation for Grails domains [grails-core]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei merged PR #16121:
URL: https://github.com/apache/grails-core/pull/16121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `@ManagedEntity` compilation for Grails domains [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16121:
URL: https://github.com/apache/grails-core/pull/16121#issuecomment-5239736901
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16121?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 52.3497%. Comparing base ([`a1e526f`](https://app.codecov.io/gh/apache/grails-core/commit/a1e526fd021afede1ec93a83eee6597fa9c024f5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`9b508ab`](https://app.codecov.io/gh/apache/grails-core/commit/9b508ab3faac254a254435e064b4fe8f1431c9ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 19 commits behind head on 8.0.x.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 8.0.x #16121 +/- ##
==================================================
+ Coverage 52.3431% 52.3497% +0.0066%
- Complexity 18296 18302 +6
==================================================
Files 2036 2036
Lines 96347 96373 +26
Branches 16829 16836 +7
==================================================
+ Hits 50431 50451 +20
- Misses 38492 38498 +6
Partials 7424 7424
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16121/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix `@ManagedEntity` compilation for Grails domains [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16121:
URL: https://github.com/apache/grails-core/pull/16121#issuecomment-5241320936
## ✅ All tests passed ✅
🏷️ Commit: 91ee8a82837b7e4a322357cd23638634aaa4e6c9
▶️ Tests: 60617 executed
⚪️ Checks: 62/62 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org