You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/06/05 05:36:32 UTC

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit 

Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7077

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................

IMPALA-5433: Mark single-argument Status c'tors as explicit

Avoid unexpected errors by marking Status c'tors as explicit. Per Google
style guide, >1 arg c'tors are not marked as explicit to allow for
copy-initialization.

Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Testing: compiled impalad and be-test.
---
M be/src/common/status.h
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/runtime/coordinator.cc
M be/src/util/codec.cc
4 files changed, 8 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/7077/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 3: Code-Review+2

Carry +2

-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has uploaded a new patch set (#2).

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................

IMPALA-5433: Mark single-argument Status c'tors as explicit

Avoid unexpected errors by marking Status c'tors as explicit. Per Google
style guide, >1 arg c'tors are not marked as explicit to allow for
copy-initialization.

Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Testing: compiled impalad and be-test.
---
M be/src/common/status.h
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/runtime/coordinator.cc
M be/src/util/codec.cc
4 files changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/7077/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 3: Verified-1

Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/678/

-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 2:

If you want to get fancy with it, you can check this with clang-tidy: http://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html

-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7077/1/be/src/common/status.h
File be/src/common/status.h:

Line 181:   Status(const TStatus& status);
> Should this one be explicit, too?
Done


Line 189:   Status(const apache::hive::service::cli::thrift::TStatus& hs2_status);
> And this one?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 3:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/678/

-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 1:

(2 comments)

I marked two more single-argument c'tors, but I'm not sure if they are likely to be used implicitly by developers.

http://gerrit.cloudera.org:8080/#/c/7077/1/be/src/common/status.h
File be/src/common/status.h:

Line 181:   Status(const TStatus& status);
Should this one be explicit, too?


Line 189:   Status(const apache::hive::service::cli::thrift::TStatus& hs2_status);
And this one?


-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7077

to look at the new patch set (#3).

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................

IMPALA-5433: Mark single-argument Status c'tors as explicit

Avoid unexpected errors by marking Status c'tors as explicit. Per Google
style guide, >1 arg c'tors are not marked as explicit to allow for
copy-initialization.

Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Testing: compiled impalad and be-test.
---
M be/src/common/status.h
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/runtime/coordinator.cc
M be/src/util/codec.cc
4 files changed, 15 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/7077/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 3:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/677/

-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


Patch Set 3:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/682/

-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5433: Mark single-argument Status c'tors as explicit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5433: Mark single-argument Status c'tors as explicit
......................................................................


IMPALA-5433: Mark single-argument Status c'tors as explicit

Avoid unexpected errors by marking Status c'tors as explicit. Per Google
style guide, >1 arg c'tors are not marked as explicit to allow for
copy-initialization.

Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Testing: compiled impalad and be-test.
Reviewed-on: http://gerrit.cloudera.org:8080/7077
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/common/status.h
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/runtime/coordinator.cc
M be/src/util/codec.cc
4 files changed, 15 insertions(+), 16 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Henry Robinson: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7077
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I64cb51151673566df973db7b0dd574b7ead27377
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>