You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/03/04 17:08:07 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17421: [refactor](functioncontext) remove duplicate type definition in function context
github-actions[bot] commented on code in PR #17421:
URL: https://github.com/apache/doris/pull/17421#discussion_r1125502993
##########
be/src/runtime/collection_value.h:
##########
@@ -21,13 +21,13 @@
#include "runtime/primitive_type.h"
-namespace doris_udf {
+namespace doris {
class FunctionContext;
-} // namespace doris_udf
+} // namespace doris
namespace doris {
-using doris_udf::FunctionContext;
+using doris::FunctionContext;
Review Comment:
warning: using decl 'FunctionContext' is unused [misc-unused-using-decls]
```cpp
using doris::FunctionContext;
^
```
**be/src/runtime/collection_value.h:29:** remove the using
```cpp
using doris::FunctionContext;
^
```
##########
be/src/udf/udf.h:
##########
@@ -430,10 +367,10 @@
bool operator!=(const DecimalV2Val& other) const { return !(*this == other); }
};
-using doris_udf::BigIntVal;
-using doris_udf::DoubleVal;
-using doris_udf::StringVal;
-using doris_udf::DecimalV2Val;
-using doris_udf::DateTimeVal;
-using doris_udf::FunctionContext;
-} // namespace doris_udf
+using doris::BigIntVal;
+using doris::DoubleVal;
Review Comment:
warning: using decl 'DoubleVal' is unused [misc-unused-using-decls]
```cpp
using doris::DoubleVal;
^
```
**be/src/udf/udf.h:370:** remove the using
```cpp
using doris::DoubleVal;
^
```
##########
be/src/udf/udf.h:
##########
@@ -430,10 +367,10 @@ struct DecimalV2Val : public AnyVal {
bool operator!=(const DecimalV2Val& other) const { return !(*this == other); }
};
-using doris_udf::BigIntVal;
-using doris_udf::DoubleVal;
-using doris_udf::StringVal;
-using doris_udf::DecimalV2Val;
-using doris_udf::DateTimeVal;
-using doris_udf::FunctionContext;
-} // namespace doris_udf
+using doris::BigIntVal;
Review Comment:
warning: using decl 'BigIntVal' is unused [misc-unused-using-decls]
```cpp
using doris::BigIntVal;
^
```
**be/src/udf/udf.h:369:** remove the using
```cpp
using doris::BigIntVal;
^
```
##########
be/src/udf/udf.h:
##########
@@ -430,10 +367,10 @@
bool operator!=(const DecimalV2Val& other) const { return !(*this == other); }
};
-using doris_udf::BigIntVal;
-using doris_udf::DoubleVal;
-using doris_udf::StringVal;
-using doris_udf::DecimalV2Val;
-using doris_udf::DateTimeVal;
-using doris_udf::FunctionContext;
-} // namespace doris_udf
+using doris::BigIntVal;
+using doris::DoubleVal;
+using doris::StringVal;
Review Comment:
warning: using decl 'StringVal' is unused [misc-unused-using-decls]
```cpp
using doris::StringVal;
^
```
**be/src/udf/udf.h:371:** remove the using
```cpp
using doris::StringVal;
^
```
##########
be/src/udf/udf.h:
##########
@@ -430,10 +367,10 @@
bool operator!=(const DecimalV2Val& other) const { return !(*this == other); }
};
-using doris_udf::BigIntVal;
-using doris_udf::DoubleVal;
-using doris_udf::StringVal;
-using doris_udf::DecimalV2Val;
-using doris_udf::DateTimeVal;
-using doris_udf::FunctionContext;
-} // namespace doris_udf
+using doris::BigIntVal;
+using doris::DoubleVal;
+using doris::StringVal;
+using doris::DecimalV2Val;
Review Comment:
warning: using decl 'DecimalV2Val' is unused [misc-unused-using-decls]
```cpp
using doris::DecimalV2Val;
^
```
**be/src/udf/udf.h:372:** remove the using
```cpp
using doris::DecimalV2Val;
^
```
##########
be/src/udf/udf.h:
##########
@@ -430,10 +367,10 @@
bool operator!=(const DecimalV2Val& other) const { return !(*this == other); }
};
-using doris_udf::BigIntVal;
-using doris_udf::DoubleVal;
-using doris_udf::StringVal;
-using doris_udf::DecimalV2Val;
-using doris_udf::DateTimeVal;
-using doris_udf::FunctionContext;
-} // namespace doris_udf
+using doris::BigIntVal;
+using doris::DoubleVal;
+using doris::StringVal;
+using doris::DecimalV2Val;
+using doris::DateTimeVal;
Review Comment:
warning: using decl 'DateTimeVal' is unused [misc-unused-using-decls]
```cpp
using doris::DateTimeVal;
^
```
**be/src/udf/udf.h:373:** remove the using
```cpp
using doris::DateTimeVal;
^
```
##########
be/src/udf/udf.h:
##########
@@ -430,10 +367,10 @@
bool operator!=(const DecimalV2Val& other) const { return !(*this == other); }
};
-using doris_udf::BigIntVal;
-using doris_udf::DoubleVal;
-using doris_udf::StringVal;
-using doris_udf::DecimalV2Val;
-using doris_udf::DateTimeVal;
-using doris_udf::FunctionContext;
-} // namespace doris_udf
+using doris::BigIntVal;
+using doris::DoubleVal;
+using doris::StringVal;
+using doris::DecimalV2Val;
+using doris::DateTimeVal;
+using doris::FunctionContext;
Review Comment:
warning: using decl 'FunctionContext' is unused [misc-unused-using-decls]
```cpp
using doris::FunctionContext;
^
```
**be/src/udf/udf.h:374:** remove the using
```cpp
using doris::FunctionContext;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org