You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/05 08:09:15 UTC

[GitHub] [druid] bananaaggle commented on pull request #11377: Add Environment Variable DynamicConfigProvider

bananaaggle commented on pull request #11377:
URL: https://github.com/apache/druid/pull/11377#issuecomment-893256818


   > LGTM. Thanks @bananaaggle!
   
   Thank you very much for review! In [11389](https://github.com/apache/druid/pull/11389), I make a design to replace PasswordProvider, but I'm not sure this design is proper or not. Can you help review it? If design is proper, I will involve more classes which use PasswordProvider in that PR. I also comment about it in [9351](https://github.com/apache/druid/issues/9351).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org