You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/07/10 10:54:48 UTC
[GitHub] [maven-javadoc-plugin] elharo opened a new pull request, #218: [MJAVADOC-762] don't share state between tests
elharo opened a new pull request, #218:
URL: https://github.com/apache/maven-javadoc-plugin/pull/218
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-762] don't share state between tests [maven-javadoc-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #218:
URL: https://github.com/apache/maven-javadoc-plugin/pull/218#issuecomment-2957401309
Resolve #1140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] elharo commented on a diff in pull request #218: [MJAVADOC-762] don't share state between tests
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #218:
URL: https://github.com/apache/maven-javadoc-plugin/pull/218#discussion_r1335757775
##########
src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java:
##########
@@ -78,27 +79,37 @@ public class JavadocReportTest extends AbstractMojoTestCase {
public static final String OPTIONS_UMLAUT_ENCODING = "Options Umlaut Encoding ö ä ü ß";
- /** flag to copy repo only one time */
- private static boolean TEST_REPO_CREATED = false;
-
private Path unit;
private File localRepo;
private static final Logger LOGGER = LoggerFactory.getLogger(JavadocReportTest.class);
- /** {@inheritDoc} */
@Override
protected void setUp() throws Exception {
super.setUp();
+ Path folder = Files.createTempDirectory("JavadocReportTest");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] elharo merged pull request #218: [MJAVADOC-762] don't share state between tests
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #218:
URL: https://github.com/apache/maven-javadoc-plugin/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #218: [MJAVADOC-762] don't share state between tests
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #218:
URL: https://github.com/apache/maven-javadoc-plugin/pull/218#discussion_r1335746601
##########
src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java:
##########
@@ -78,27 +79,37 @@ public class JavadocReportTest extends AbstractMojoTestCase {
public static final String OPTIONS_UMLAUT_ENCODING = "Options Umlaut Encoding ö ä ü ß";
- /** flag to copy repo only one time */
- private static boolean TEST_REPO_CREATED = false;
-
private Path unit;
private File localRepo;
private static final Logger LOGGER = LoggerFactory.getLogger(JavadocReportTest.class);
- /** {@inheritDoc} */
@Override
protected void setUp() throws Exception {
super.setUp();
+ Path folder = Files.createTempDirectory("JavadocReportTest");
Review Comment:
directory, not folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org