[jira] Commented: (SHINDIG-671) setUserPref problems in gadgets.js

["Tom Deckers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652499#action_12652499 ] 

Tom Deckers commented on SHINDIG-671:
-------------------------------------

That patch file was helpful to me.  However, the following section didn't do the trick for me either:
   for (var i = 1, j = arguments.length; i < j; i += 2) {
     prefs[arguments[i]] = arguments[i + 1];
   }

When replaced by a simple:
  prefs[name] = value;

... things worked.

Any thoughts?

Regards,
Tom.

> setUserPref problems in gadgets.js
> ----------------------------------
>
>                 Key: SHINDIG-671
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-671
>             Project: Shindig
>          Issue Type: Bug
>          Components: Sample container & Examples
>         Environment: FireFox
>            Reporter: David Citron
>         Attachments: shindig-671.patch
>
>
> gadgets.IfrGadgetService.prototype.setUserPref appears to have multiple issues:
> 1) its callback registration looses the "this" pointer, causing JS errors (cannot find other methods in its object)
> 2) it does not handle the case where the gadget does not yet have prefs set (prefs undefined error)
> I will attach a patch that worked for me to resolve these issues. Please take a look and determine if the patch is correct or if perhaps some usage pattern of mine is causing the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.