You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by laurentgo <gi...@git.apache.org> on 2016/01/21 19:21:13 UTC
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
GitHub user laurentgo opened a pull request:
https://github.com/apache/drill/pull/333
DRILL-4295: Removes obsolete protobuf-generated files
These files are obsolete protobuf-generated files, whose definition has been removed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laurentgo/drill laurent/removes-obsolete-protobuf-files
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/333.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #333
----
commit 12586e59b0a13f1b7d52768790cfd4e33934d7ad
Author: Laurent Goujon <la...@dremio.com>
Date: 2016-01-21T18:16:29Z
Removes obsolete protobuf-generated files
These files are obsolete protobuf-generated files, whose definition has been
removed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/333#issuecomment-173713031
I'm not sure it is a simple option. I believe we have to worry about version conflicts between Drill, HDFS, HBase and MapRFS. (We used to shade for this purpose but we stopped once we were all on the same version).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/333
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
Posted by laurentgo <gi...@git.apache.org>.
Github user laurentgo commented on the pull request:
https://github.com/apache/drill/pull/333#issuecomment-173687545
If changing protobuf version to 2.6.1 is an option, maven central now has protoc version for each architecture, that the protobuf maven plugin can take advantage of: http://sergei-ivanov.github.io/maven-protoc-plugin/faq.html#faq_1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
Posted by laurentgo <gi...@git.apache.org>.
Github user laurentgo commented on the pull request:
https://github.com/apache/drill/pull/333#issuecomment-173742695
I was expecting this, so I added the clean before generate source code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/333#issuecomment-173683725
Fair question. For the first year the codebase only generated these files at build time (no check-in). In this situation newcomers had to install the right version of protoc. This turned into the single biggest issue on the dev list to new contributors. As such, we finally relented and committed the compiled code. (In general, the problem is that if brew/macports installs the wrong version, people get strange maven compilation problems that are non-obvious).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/333#issuecomment-173678237
Can you look at a way to update the -Pproto-compile code so it first deletes all the files so we don't have this kind of problem in the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/333#issuecomment-180477807
+1 on the clean change and removal of unnecessary files.
If we want to try to clean up the build process to not check in the generated files, I assume that will be done in a follow up PR.
For now it doesn't sound like it's worth the hassle though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4295: Removes obsolete protobuf-generate...
Posted by laurentgo <gi...@git.apache.org>.
Github user laurentgo commented on the pull request:
https://github.com/apache/drill/pull/333#issuecomment-173681422
I can check on how to delete first, but maybe you can share why these files are persisted in the first place under git, versus being generated everytime: is it because you have to install protobuf compiler first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---