You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2022/10/24 11:54:54 UTC
[kudu-CR] [Tools][Bugfix] Fix bug of tablet copier which will cause core dump
Wang Xixu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19163
Change subject: [Tools][Bugfix] Fix bug of tablet copier which will cause core dump
......................................................................
[Tools][Bugfix] Fix bug of tablet copier which will cause core dump
The function: CopyTablets() of class TabletCopier creates a thread to obtain copy process periodically,
every 10 seconds, it will log the tablet id and tablet status. But fake_replica does not have a tablet id,
here will core dump.
Therefore, this patch uses map<string, TabletReplica*> copying_replicas_by_tablet_id to store the tablet id
and fake_replica.
Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/19163/1
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
[kudu-CR] [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19163 )
Change subject: [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
......................................................................
[KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
The function: CopyTablets() of class TabletCopier creates
a thread to obtain copy process periodically. Every 10s,
it will log the tablet id and tablet status. But fake_replica
does not have a tablet id, here will core dump.
Therefore, this patch uses map<string, TabletReplica*>
copying_replicas_by_tablet_id to store the tablet id and
fake_replica.
Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Reviewed-on: http://gerrit.cloudera.org:8080/19163
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Tested-by: Yingchun Lai <ac...@gmail.com>
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 9 insertions(+), 7 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [Tools][Bugfix] Fix core dump of tablet copier
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19163 )
Change subject: [Tools][Bugfix] Fix core dump of tablet copier
......................................................................
Patch Set 3:
(3 comments)
> Patch Set 2: Code-Review+1
>
> (3 comments)
http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG@9
PS2, Line 9: The function: CopyTablets() of class TabletCopier creates
> nit: It's too wide, it's recommend to obey the 50/72 commit message rule [1
Done
http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG@11
PS2, Line 11: g the tab
> Could you please create an JIRA and attach some pics/logs about it?
Done
http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc@35
PS2, Line 35: #include <boost/container/vector.hpp>
> Where use it?
IWYU reminds me to use it.
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Oct 2022 07:48:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19163
to look at the new patch set (#5).
Change subject: [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
......................................................................
[KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
The function: CopyTablets() of class TabletCopier creates
a thread to obtain copy process periodically. Every 10s,
it will log the tablet id and tablet status. But fake_replica
does not have a tablet id, here will core dump.
Therefore, this patch uses map<string, TabletReplica*>
copying_replicas_by_tablet_id to store the tablet id and
fake_replica.
Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/19163/5
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [Tools][Bugfix] Fix core dump of tablet copier
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19163
to look at the new patch set (#3).
Change subject: [Tools][Bugfix] Fix core dump of tablet copier
......................................................................
[Tools][Bugfix] Fix core dump of tablet copier
The function: CopyTablets() of class TabletCopier creates
a thread to obtain copy process periodically. Every 10s,
it will log the tablet id and tablet status. But fake_replica
does not have a tablet id, here will core dump.
Therefore, this patch uses map<string, TabletReplica*>
copying_replicas_by_tablet_id to store the tablet id and
fake_replica.
Related issue: https://issues.apache.org/jira/browse/KUDU-3412
Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/19163/3
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [Tools][Bugfix] Fix bug of tablet copier which will cause core dump
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19163
to look at the new patch set (#2).
Change subject: [Tools][Bugfix] Fix bug of tablet copier which will cause core dump
......................................................................
[Tools][Bugfix] Fix bug of tablet copier which will cause core dump
The function: CopyTablets() of class TabletCopier creates a thread to obtain copy process periodically,
every 10 seconds, it will log the tablet id and tablet status. But fake_replica does not have a tablet id,
here will core dump.
Therefore, this patch uses map<string, TabletReplica*> copying_replicas_by_tablet_id to store the tablet id
and fake_replica.
Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/19163/2
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [Tools][Bugfix] Fix bug of tablet copier which will cause core dump
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19163 )
Change subject: [Tools][Bugfix] Fix bug of tablet copier which will cause core dump
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG@9
PS2, Line 9: The function: CopyTablets() of class TabletCopier creates a thread to obtain copy process periodically,
nit: It's too wide, it's recommend to obey the 50/72 commit message rule [1].
1. https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines
http://gerrit.cloudera.org:8080/#/c/19163/2//COMMIT_MSG@11
PS2, Line 11: core dump
Could you please create an JIRA and attach some pics/logs about it?
http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc@35
PS2, Line 35: #include <boost/container/vector.hpp>
Where use it?
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 25 Oct 2022 06:35:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19163
to look at the new patch set (#4).
Change subject: [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
......................................................................
[KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
The function: CopyTablets() of class TabletCopier creates
a thread to obtain copy process periodically. Every 10s,
it will log the tablet id and tablet status. But fake_replica
does not have a tablet id, here will core dump.
Therefore, this patch uses map<string, TabletReplica*>
copying_replicas_by_tablet_id to store the tablet id and
fake_replica.
Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/19163/4
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [Tools][Bugfix] Fix core dump of tablet copier
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19163 )
Change subject: [Tools][Bugfix] Fix core dump of tablet copier
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19163/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19163/3//COMMIT_MSG@7
PS3, Line 7: [Tools][Bugfix] Fix core dump of tablet copier
nit: add 'KUDU-3412' at the begining of title, and then remove line 18.
http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc@35
PS2, Line 35: #include <boost/container/vector.hpp>
> IWYU reminds me to use it.
It seems a misreport, try to use '// IWYU pragma: no_include <boost/container/vector.hpp>' to mute it.
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 02:37:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19163
to look at the new patch set (#6).
Change subject: [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
......................................................................
[KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
The function: CopyTablets() of class TabletCopier creates
a thread to obtain copy process periodically. Every 10s,
it will log the tablet id and tablet status. But fake_replica
does not have a tablet id, here will core dump.
Therefore, this patch uses map<string, TabletReplica*>
copying_replicas_by_tablet_id to store the tablet id and
fake_replica.
Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
---
M src/kudu/tools/tool_action_local_replica.cc
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/19163/6
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19163 )
Change subject: [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19163/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19163/3//COMMIT_MSG@7
PS3, Line 7: [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
> nit: add 'KUDU-3412' at the begining of title, and then remove line 18.
Done
http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:
http://gerrit.cloudera.org:8080/#/c/19163/2/src/kudu/tools/tool_action_local_replica.cc@35
PS2, Line 35: #include <gflags/gflags.h>
> It seems a misreport, try to use '// IWYU pragma: no_include <boost/contain
Done
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 03:08:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19163 )
Change subject: [KUDU-3412][Tools][Bugfix] Fix core dump of tablet copier
......................................................................
Patch Set 6: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa2107d3c04c9f3e850d33dbf420ebb62edc98d8
Gerrit-Change-Number: 19163
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 09:05:00 +0000
Gerrit-HasComments: No