You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2024/11/11 14:49:25 UTC
Re: [PR] [SPARK-50110][SQL] Fix read csv fails when data contains spaces before and after [spark]
panbingkun commented on PR #48653:
URL: https://github.com/apache/spark/pull/48653#issuecomment-2468358508
> Let's make it clear in the PR title and description.
Updated.
> Are you suggesting to turn on `ignoreLeadingWhiteSpace` by default?
I think this is indeed a solution that can solve similar scenarios, but will it affect the reading performance of data without spaces? I am not sure because I have preliminarily looked at the `CsvParser` logic and it is as follows:
<img width="714" alt="image" src="https://github.com/user-attachments/assets/0eae4f28-b19c-45c4-af53-689c407f1947">
<img width="954" alt="image" src="https://github.com/user-attachments/assets/f939daf8-ae8c-4aab-946e-a5760ce0e3a9">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org