You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/04 21:54:59 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #22591: fix: Talisman configuration
michael-s-molina opened a new pull request, #22591:
URL: https://github.com/apache/superset/pull/22591
### SUMMARY
https://github.com/apache/superset/pull/21874 introduced a CSP check for production environments but ended up making the Talisman configuration dependent on the `CONTENT_SECURITY_POLICY_WARNING` key. This PR fixes this by loading Talisman values independently of the CSP warning.
### TESTING INSTRUCTIONS
1 - Play with Talisman configurations
2 - Check that the Talisman configurations are applied independently of the CSP warning
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22591: fix: Talisman configuration
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22591:
URL: https://github.com/apache/superset/pull/22591#issuecomment-1371483561
# [Codecov](https://codecov.io/gh/apache/superset/pull/22591?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22591](https://codecov.io/gh/apache/superset/pull/22591?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f310c8c) into [master](https://codecov.io/gh/apache/superset/commit/82b0c23fb294808bba931fc052ce438d0f2f5c45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (82b0c23) will **increase** coverage by `0.00%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head f310c8c differs from pull request most recent head 9d8754a. Consider uploading reports for the commit 9d8754a to get more accurate results
```diff
@@ Coverage Diff @@
## master #22591 +/- ##
=======================================
Coverage 55.91% 55.91%
=======================================
Files 1859 1859
Lines 71019 71020 +1
Branches 7766 7766
=======================================
+ Hits 39710 39713 +3
+ Misses 29287 29285 -2
Partials 2022 2022
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.47% <83.33%> (+<0.01%)` | :arrow_up: |
| presto | `52.37% <83.33%> (+<0.01%)` | :arrow_up: |
| python | `58.16% <83.33%> (+<0.01%)` | :arrow_up: |
| unit | `51.46% <83.33%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/22591?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `91.74% <83.33%> (+0.68%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #22591: fix: Talisman configuration
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed pull request #22591: fix: Talisman configuration
URL: https://github.com/apache/superset/pull/22591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org