You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/17 13:27:08 UTC
[GitHub] [flink] knaufk commented on a change in pull request #19111: [hotfix] [docs] fix first example in table API documentation
knaufk commented on a change in pull request #19111:
URL: https://github.com/apache/flink/pull/19111#discussion_r829114337
##########
File path: docs/content/docs/dev/table/common.md
##########
@@ -50,26 +50,26 @@ tableEnv.createTemporaryTable("SourceTable", TableDescriptor.forConnector("datag
.schema(Schema.newBuilder()
.column("f0", DataTypes.STRING())
.build())
- .option(DataGenOptions.ROWS_PER_SECOND, 100)
- .build())
+ .option(DataGenConnectorOptions.ROWS_PER_SECOND, 100L)
+ .build());
// Create a sink table (using SQL DDL)
-tableEnv.executeSql("CREATE TEMPORARY TABLE SinkTable WITH ('connector' = 'blackhole') LIKE SourceTable");
+tableEnv.executeSql("CREATE TEMPORARY TABLE SinkTable WITH ('connector' = 'blackhole') LIKE SourceTable (EXCLUDING OPTIONS)");
// Create a Table object from a Table API query
-Table table2 = tableEnv.from("SourceTable");
+Table table1 = tableEnv.from("SourceTable");
// Create a Table object from a SQL query
-Table table3 = tableEnv.sqlQuery("SELECT * FROM SourceTable");
+Table table2 = tableEnv.sqlQuery("SELECT * FROM SourceTable");
// Emit a Table API result Table to a TableSink, same for SQL result
-TableResult tableResult = table2.insertInto("SinkTable").execute();
+TableResult tableResult = table1.insertInto("SinkTable").execute();
```
{{< /tab >}}
{{< tab "Scala" >}}
```scala
import org.apache.flink.table.api._
-import org.apache.flink.connector.datagen.table.DataGenOptions
+import org.apache.flink.connector.datagen.table.DataGenConnectorOptions;
Review comment:
Thanks. Fixed.
##########
File path: docs/content.zh/docs/dev/table/common.md
##########
@@ -52,26 +52,27 @@ tableEnv.createTemporaryTable("SourceTable", TableDescriptor.forConnector("datag
.schema(Schema.newBuilder()
.column("f0", DataTypes.STRING())
.build())
- .option(DataGenOptions.ROWS_PER_SECOND, 100)
- .build())
+ .option(DataGenConnectorOptions.ROWS_PER_SECOND, 100L)
+ .build());
// Create a sink table (using SQL DDL)
-tableEnv.executeSql("CREATE TEMPORARY TABLE SinkTable WITH ('connector' = 'blackhole') LIKE SourceTable");
+tableEnv.executeSql("CREATE TEMPORARY TABLE SinkTable WITH ('connector' = 'blackhole') LIKE SourceTable (EXCLUDING OPTIONS)");
// Create a Table object from a Table API query
-Table table2 = tableEnv.from("SourceTable");
+Table table1 = tableEnv.from("SourceTable");
// Create a Table object from a SQL query
-Table table3 = tableEnv.sqlQuery("SELECT * FROM SourceTable");
+Table table2 = tableEnv.sqlQuery("SELECT * FROM SourceTable");
// Emit a Table API result Table to a TableSink, same for SQL result
-TableResult tableResult = table2.executeInsert("SinkTable");
+TableResult tableResult = table2.insertInto("SinkTable").execute();
```
{{< /tab >}}
{{< tab "Scala" >}}
```scala
import org.apache.flink.table.api._
-import org.apache.flink.connector.datagen.table.DataGenOptions
+import org.apache.flink.connector.datagen.table.DataGenConnectorOptions;
+import org.apache.flink.table.api.bridge.scala.StreamTableEnvironment
Review comment:
I don't. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org