You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/27 15:21:41 UTC

[GitHub] [apisix] zuiyangqingzhou opened a new issue, #8193: help request: Questions about global plugins and plugins on the route

zuiyangqingzhou opened a new issue, #8193:
URL: https://github.com/apache/apisix/issues/8193

   ### Description
   
   I've enabled a global plugin, such as limit-count, which returns 403 in the access phase when a certain threshold is reached, and I've enabled the response_rewrite plugin on route X.
   
   I find that the header_filter phase of the response_rewrite plugin does not execute when I keep requesting route X that is restricted to return 403.
   
   Is it normal ?
   
   ### Environment
   
   - APISIX version (run `apisix version`):  2.10.5
   - Operating system (run `uname -a`):
   - OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
   - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`):
   - APISIX Dashboard version, if relevant:
   - Plugin runner version, for issues related to plugin runners:
   - LuaRocks version, for installation issues (run `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] zuiyangqingzhou commented on issue #8193: help request: Questions about global plugins and plugins on the route

Posted by GitBox <gi...@apache.org>.
zuiyangqingzhou commented on issue #8193:
URL: https://github.com/apache/apisix/issues/8193#issuecomment-1294376438

   > I checked the code, and the route-level plugin is loaded after the global rules are executed, which means that if you `exit(403)` in the global plugin, the route-level plugin will not be loaded. There are no plugins available in APISIX when `header_filter` is executed.
   
   I confirm that you mean,  if `exit(403)` in the global plugin,  the route-level plugin will not be execute? @soulbird 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] soulbird commented on issue #8193: help request: Questions about global plugins and plugins on the route

Posted by GitBox <gi...@apache.org>.
soulbird commented on issue #8193:
URL: https://github.com/apache/apisix/issues/8193#issuecomment-1294345857

   I checked the code, and the route-level plugin is loaded after the global rules are executed, which means that if you `exit(403)` in the global plugin, the route-level plugin will not be loaded. There are no plugins available in APISIX when `header_filter` is executed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] tokers commented on issue #8193: help request: Questions about global plugins and plugins on the route

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #8193:
URL: https://github.com/apache/apisix/issues/8193#issuecomment-1297881056

   We need write docs for it. I agree the design of global rule that it runs before the route match (in the access phase) but our users don't know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] shreemaan-abhishek closed issue #8193: help request: Questions about global plugins and plugins on the route

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek closed issue #8193: help request:  Questions about global plugins and plugins on the route
URL: https://github.com/apache/apisix/issues/8193


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] soulbird commented on issue #8193: help request: Questions about global plugins and plugins on the route

Posted by GitBox <gi...@apache.org>.
soulbird commented on issue #8193:
URL: https://github.com/apache/apisix/issues/8193#issuecomment-1294313601

   It doesn't look normal, do you have a reproducible test case?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] shreemaan-abhishek commented on issue #8193: help request: Questions about global plugins and plugins on the route

Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #8193:
URL: https://github.com/apache/apisix/issues/8193#issuecomment-1708090335

   closing as fixed by #9815


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [apisix] tzssangglass commented on issue #8193: help request: Questions about global plugins and plugins on the route

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #8193:
URL: https://github.com/apache/apisix/issues/8193#issuecomment-1296888759

   > I confirm that you mean, if `exit(403)` in the global plugin, the route-level plugin will not be execute? @soulbird
   
   yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org