[GitHub] [ignite] tledkov-gridgain commented on a change in pull request #9423: IGNITE-15281 New implementation of local statistics collection.

[GitBox <gi...@apache.org>]

tledkov-gridgain commented on a change in pull request #9423:
URL: https://github.com/apache/ignite/pull/9423#discussion_r724319407



##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/BusyExecutor.java
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.query.stat;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.function.Function;
+import org.apache.ignite.IgniteLogger;
+import org.apache.ignite.internal.util.GridBusyLock;
+import org.apache.ignite.thread.IgniteThreadPoolExecutor;
+
+/**
+ * Executor with busy run support.
+ * Can run any tasks while active and safelly wait untill they stopped.
+ */
+public class BusyExecutor {
+    /** Logger. */
+    private final IgniteLogger log;
+
+    /** Executor name. */
+    private final String name;
+
+    /** Active flag (used to skip commands in inactive cluster.) */
+    private volatile boolean active;
+
+    /** Lock protection of started gathering during deactivation. */
+    private final GridBusyLock busyLock = new GridBusyLock();
+
+    /** Executor pool. */
+    private final IgniteThreadPoolExecutor pool;
+
+    /**
+     * Constructor.
+     *
+     * @param name Executor name.
+     * @param pool Underlying thread pool executor.
+     * @param logSupplier Log supplier.
+     */
+    public BusyExecutor(String name, IgniteThreadPoolExecutor pool, Function<Class<?>, IgniteLogger> logSupplier) {
+        this.name = name;
+        this.pool = pool;
+        this.log = logSupplier.apply(StatisticsProcessor.class);
+    }
+
+    /**
+     * Allow operations.
+     */
+    public void activate() {
+        active = true;
+
+        if (log.isDebugEnabled())
+            log.debug("Busy executor " + name + " activated.");
+    }
+
+    /**
+     * Stop all running tasks. Block new task scheduling, execute cancell runnable and wait till each task stops.
+     *
+     * @param r Runnable to cancel all scheduled tasks.
+     */
+    public void deactivate(Runnable r) {
+        active = false;
+
+        if (log.isDebugEnabled())
+            log.debug("Busy executor " + name + " deactivating.");
+
+        r.run();

Review comment:
       What happens when deactivating a task throws an exception?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org