You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/11/11 13:24:37 UTC

svn commit: r1894951 - /poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/StreamingSheetWriter.java

Author: fanningpj
Date: Thu Nov 11 13:24:37 2021
New Revision: 1894951

URL: http://svn.apache.org/viewvc?rev=1894951&view=rev
Log:
try to handle logging issue where DeferredSXSSFWorkbook close can lead to logging about close already having been called

Modified:
    poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/StreamingSheetWriter.java

Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/StreamingSheetWriter.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/StreamingSheetWriter.java?rev=1894951&r1=1894950&r2=1894951&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/StreamingSheetWriter.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/StreamingSheetWriter.java Thu Nov 11 13:24:37 2021
@@ -37,6 +37,7 @@ import org.apache.poi.util.Beta;
 @Beta
 public class StreamingSheetWriter extends SheetDataWriter {
     private static final Logger LOG = LogManager.getLogger(StreamingSheetWriter.class);
+    private boolean closed = false;
 
     public StreamingSheetWriter() throws IOException {
         throw new RuntimeException("StreamingSheetWriter requires OutputStream");
@@ -68,7 +69,9 @@ public class StreamingSheetWriter extend
 
     @Override
     public void close() throws IOException {
-        _out.flush();
+        if (!closed) {
+            _out.flush();
+        }
     }
 
     @Override
@@ -78,7 +81,10 @@ public class StreamingSheetWriter extend
 
     @Override
     boolean dispose() throws IOException {
-        _out.close();
+        if (!closed) {
+            _out.close();
+        }
+        closed = true;
         return true;
     }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org