[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #19855: feat(explore): Frontend implementation of dataset creation from infobox

[GitBox <gi...@apache.org>]

lyndsiWilliams commented on code in PR #19855:
URL: https://github.com/apache/superset/pull/19855#discussion_r860192694


##########
superset-frontend/src/explore/components/DatasourcePanel/index.tsx:
##########
@@ -190,6 +217,35 @@ export default function DataSourcePanel({
     [_columns],
   );
 
+  const placeholderSlDataset = {
+    sl_table: [],

Review Comment:
   I wasn't sure what these properties were going to be but thought I needed to pass in something as a placeholder until the back end is implemented. Turns out I don't need it, so I removed it in [`this commit`](https://github.com/apache/superset/pull/19855/commits/fd65bfa6f6241c466fa4eac90efafcc87f5c95cd). Thanks for this catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org