You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Stephen Yuan Jiang (JIRA)" <ji...@apache.org> on 2015/03/16 22:23:40 UTC
[jira] [Created] (HBASE-13254) EnableTableHandler#prepare would not
throw TableNotFoundException during recovery
Stephen Yuan Jiang created HBASE-13254:
------------------------------------------
Summary: EnableTableHandler#prepare would not throw TableNotFoundException during recovery
Key: HBASE-13254
URL: https://issues.apache.org/jira/browse/HBASE-13254
Project: HBase
Issue Type: Bug
Reporter: Stephen Yuan Jiang
Assignee: Stephen Yuan Jiang
Priority: Minor
During recovery, when EnableTableHandler#prepare() is called, If the table does not exist, it marks the table as deleted and does NOT throw TableNotFoundException. The result is that the table lock is released and the caller has no knowledge that the table not exist or already deleted, it would continue the next step.
{code}
public EnableTableHandler prepare()
throws TableNotFoundException, TableNotDisabledException, IOException {
...
try {
// Check if table exists
if (!MetaTableAccessor.tableExists(this.server.getConnection(), tableName)) {
// retainAssignment is true only during recovery. In normal case it is false
if (!this.skipTableStateCheck) {
throw new TableNotFoundException(tableName);
}
this.assignmentManager.getTableStateManager().setDeletedTable(tableName);
}
...
}
{code}
However,look at the recovery code that calls the EnableTableHandler#prepare function, AssignmentManager#recoverTableInEnablingState() expects TableNotFoundException so that it can skip the table.
{code}
private void recoverTableInEnablingState()
throws KeeperException, IOException {
Set<TableName> enablingTables = tableStateManager.
getTablesInStates(TableState.State.ENABLING);
if (enablingTables.size() != 0) {
for (TableName tableName : enablingTables) {
// Recover by calling EnableTableHandler
LOG.info("The table " + tableName
+ " is in ENABLING state. Hence recovering by moving the table"
+ " to ENABLED state.");
// enableTable in sync way during master startup,
// no need to invoke coprocessor
EnableTableHandler eth = new EnableTableHandler(this.server, tableName,
this, tableLockManager, true);
try {
eth.prepare();
} catch (TableNotFoundException e) {
LOG.warn("Table " + tableName + " not found in hbase:meta to recover.");
continue;
}
eth.process();
}
}
}
{code}
The proposed fix is always throw TableNotFoundException in EnableTableHandler#prepare if the table does not exist.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)