[GitHub] ConeyLiu commented on a change in pull request #21913: [SPARK-24005][CORE] Remove usage of Scala’s parallel collection

[GitBox <gi...@apache.org>]

ConeyLiu commented on a change in pull request #21913: [SPARK-24005][CORE] Remove usage of Scala’s parallel collection
URL: https://github.com/apache/spark/pull/21913#discussion_r258039288
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/util/ThreadUtilsSuite.scala
 ##########
 @@ -133,4 +133,37 @@ class ThreadUtilsSuite extends SparkFunSuite {
       "stack trace contains unexpected references to ThreadUtils"
     )
   }
+
+  test("parmap should be interruptible") {
+    val t = new Thread() {
+      setDaemon(true)
+
+      override def run() {
+        try {
+          // "par" is uninterruptible. The following will keep running even if the thread is
+          // interrupted. We should prefer to use "ThreadUtils.parmap".
+          //
+          // (1 to 10).par.flatMap { i =>
+          //   Thread.sleep(100000)
+          //   1 to i
+          // }
+          //
+          ThreadUtils.parmap(1 to 10, "test", 2) { i =>
+            Thread.sleep(100000)
+            1 to i
+          }.flatten
+        } catch {
+          case _: InterruptedException => // excepted
+        }
+      }
+    }
+    t.start()
+    eventually(timeout(10.seconds)) {
+      assert(t.isAlive)
+    }
+    t.interrupt()
+    eventually(timeout(10.seconds)) {
+      assert(!t.isAlive)
+    }
+  }
 
 Review comment:
   Hi, @MaxGekk @zsxwing Could you tell me why this can be interrupted? while `(1 to 10).par` can't.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org