You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2018/07/26 16:24:46 UTC

[GitHub] khmarbaise commented on a change in pull request #2: Bug/MSHARED-416

khmarbaise commented on a change in pull request #2: Bug/MSHARED-416
URL: https://github.com/apache/maven-shared-utils/pull/2#discussion_r205520332
 
 

 ##########
 File path: src/test/java/org/apache/maven/shared/utils/cli/CommandLineUtilsTest.java
 ##########
 @@ -19,22 +19,29 @@
  * under the License.
  */
 
+import java.io.BufferedReader;
+import java.io.InputStreamReader;
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Locale;
 import java.util.Map;
 import java.util.Properties;
+import java.util.concurrent.TimeUnit;
+
 import org.apache.maven.shared.utils.Os;
 
-import junit.framework.TestCase;
+import org.junit.Assert;
+import org.junit.Test;
+
+import static org.junit.Assert.*;
 
 Review comment:
   Would please so nice to keep explicit import instead of asteric imports...Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services