You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Parth Brahmbhatt <br...@gmail.com> on 2014/12/30 00:03:05 UTC
Review Request 29468: Patch for KAFKA-1805
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1805
https://issues.apache.org/jira/browse/KAFKA-1805
Repository: kafka
Description
-------
KAFKA-1805: adding equals and hashcode methods to ProducerRecord.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
core/src/main/scala/kafka/consumer/ConsumerConnector.scala 62c0686e816d2888772d5a911becf625eedee397
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala e991d2187d03241f639eeaf6769fb59c8c99664c
core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala 9baad34a9793e5067d11289ece2154ba87b388af
core/src/main/scala/kafka/tools/MirrorMaker.scala 53cb16c2949e0ac36a0e943564fc9fc9b4c84caa
core/src/main/scala/kafka/utils/DoublyLinkedList.scala PRE-CREATION
core/src/test/scala/unit/kafka/utils/UtilsTest.scala 066553cad290c3d3821537a964c7d713c122d9fc
Diff: https://reviews.apache.org/r/29468/diff/
Testing
-------
Thanks,
Parth Brahmbhatt
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/#review72031
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment117965>
not intentional, removed.
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment117966>
handling null for all fields now.
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment117967>
nulls are handled now.
- Parth Brahmbhatt
On Feb. 11, 2015, 10:53 p.m., Parth Brahmbhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29468/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 10:53 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
> https://issues.apache.org/jira/browse/KAFKA-1805
> https://issues.apache.org/jira/browse/KAFKA-1905
> https://issues.apache.org/jira/browse/KAFKA-42
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
>
>
> Handling the case where al the fields in ProducerRecord can be null.
>
>
> Adding toString back.
>
>
> Added unit test for eqauls and hashcode.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
> clients/src/test/java/org/apache/kafka/clients/producer/ProducerRecordTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29468/diff/
>
>
> Testing
> -------
>
> Unit tests added.
>
>
> Thanks,
>
> Parth Brahmbhatt
>
>
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 10:53 p.m.)
Review request for kafka.
Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
https://issues.apache.org/jira/browse/KAFKA-1805
https://issues.apache.org/jira/browse/KAFKA-1905
https://issues.apache.org/jira/browse/KAFKA-42
Repository: kafka
Description
-------
Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
Handling the case where al the fields in ProducerRecord can be null.
Adding toString back.
Added unit test for eqauls and hashcode.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
clients/src/test/java/org/apache/kafka/clients/producer/ProducerRecordTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/29468/diff/
Testing (updated)
-------
Unit tests added.
Thanks,
Parth Brahmbhatt
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 10:49 p.m.)
Review request for kafka.
Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
https://issues.apache.org/jira/browse/KAFKA-1805
https://issues.apache.org/jira/browse/KAFKA-1905
https://issues.apache.org/jira/browse/KAFKA-42
Repository: kafka
Description (updated)
-------
Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
Handling the case where al the fields in ProducerRecord can be null.
Adding toString back.
Added unit test for eqauls and hashcode.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
clients/src/test/java/org/apache/kafka/clients/producer/ProducerRecordTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/29468/diff/
Testing
-------
Thanks,
Parth Brahmbhatt
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 10:37 p.m.)
Review request for kafka.
Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
https://issues.apache.org/jira/browse/KAFKA-1805
https://issues.apache.org/jira/browse/KAFKA-1905
https://issues.apache.org/jira/browse/KAFKA-42
Repository: kafka
Description
-------
Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
Handling the case where al the fields in ProducerRecord can be null.
Adding toString back.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
Diff: https://reviews.apache.org/r/29468/diff/
Testing
-------
Thanks,
Parth Brahmbhatt
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 10:37 p.m.)
Review request for kafka.
Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
https://issues.apache.org/jira/browse/KAFKA-1805
https://issues.apache.org/jira/browse/KAFKA-1905
https://issues.apache.org/jira/browse/KAFKA-42
Repository: kafka
Description
-------
Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
Handling the case where al the fields in ProducerRecord can be null.
Adding toString back.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
Diff: https://reviews.apache.org/r/29468/diff/
Testing
-------
Thanks,
Parth Brahmbhatt
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
> On Feb. 11, 2015, 10:35 p.m., Gwen Shapira wrote:
> > Can you add unit tests?
Added uni tests.
- Parth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/#review72032
-----------------------------------------------------------
On Feb. 11, 2015, 10:49 p.m., Parth Brahmbhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29468/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 10:49 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
> https://issues.apache.org/jira/browse/KAFKA-1805
> https://issues.apache.org/jira/browse/KAFKA-1905
> https://issues.apache.org/jira/browse/KAFKA-42
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
>
>
> Handling the case where al the fields in ProducerRecord can be null.
>
>
> Adding toString back.
>
>
> Added unit test for eqauls and hashcode.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
> clients/src/test/java/org/apache/kafka/clients/producer/ProducerRecordTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/29468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Parth Brahmbhatt
>
>
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/#review72032
-----------------------------------------------------------
Can you add unit tests?
- Gwen Shapira
On Feb. 11, 2015, 10:34 p.m., Parth Brahmbhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29468/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 10:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
> https://issues.apache.org/jira/browse/KAFKA-1805
> https://issues.apache.org/jira/browse/KAFKA-1905
> https://issues.apache.org/jira/browse/KAFKA-42
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
>
>
> Handling the case where al the fields in ProducerRecord can be null.
>
>
> Adding toString back.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
>
> Diff: https://reviews.apache.org/r/29468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Parth Brahmbhatt
>
>
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 10:34 p.m.)
Review request for kafka.
Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
https://issues.apache.org/jira/browse/KAFKA-1805
https://issues.apache.org/jira/browse/KAFKA-1905
https://issues.apache.org/jira/browse/KAFKA-42
Repository: kafka
Description (updated)
-------
Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
Handling the case where al the fields in ProducerRecord can be null.
Adding toString back.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
Diff: https://reviews.apache.org/r/29468/diff/
Testing
-------
Thanks,
Parth Brahmbhatt
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 10:30 p.m.)
Review request for kafka.
Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
https://issues.apache.org/jira/browse/KAFKA-1805
https://issues.apache.org/jira/browse/KAFKA-1905
https://issues.apache.org/jira/browse/KAFKA-42
Repository: kafka
Description (updated)
-------
Merge remote-tracking branch 'origin/trunk' into KAFKA-1805
Handling the case where al the fields in ProducerRecord can be null.
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
Diff: https://reviews.apache.org/r/29468/diff/
Testing
-------
Thanks,
Parth Brahmbhatt
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/#review66688
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment110269>
Most of the values in ProducerRecord can be null. That condition needs to be handled here as well as in hashCode()
- Ewen Cheslack-Postava
On Dec. 30, 2014, 12:37 a.m., Parth Brahmbhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29468/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 12:37 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
> https://issues.apache.org/jira/browse/KAFKA-1805
> https://issues.apache.org/jira/browse/KAFKA-1905
> https://issues.apache.org/jira/browse/KAFKA-42
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1805: adding equals and hashcode methods to ProducerRecord.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
>
> Diff: https://reviews.apache.org/r/29468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Parth Brahmbhatt
>
>
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/#review71572
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment117334>
Is this intentional?
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment117335>
Theoretically partitionId can be null also.
- Guozhang Wang
On Dec. 30, 2014, 12:37 a.m., Parth Brahmbhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29468/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 12:37 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
> https://issues.apache.org/jira/browse/KAFKA-1805
> https://issues.apache.org/jira/browse/KAFKA-1905
> https://issues.apache.org/jira/browse/KAFKA-42
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1805: adding equals and hashcode methods to ProducerRecord.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
>
> Diff: https://reviews.apache.org/r/29468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Parth Brahmbhatt
>
>
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Eric Olander <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/#review71928
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java
<https://reviews.apache.org/r/29468/#comment117848>
return key.equals(that.key) && partition.equals(that.partition) && topic.equals(that.topic) && value.equals(that.value);
- Eric Olander
On Dec. 30, 2014, 12:37 a.m., Parth Brahmbhatt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29468/
> -----------------------------------------------------------
>
> (Updated Dec. 30, 2014, 12:37 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
> https://issues.apache.org/jira/browse/KAFKA-1805
> https://issues.apache.org/jira/browse/KAFKA-1905
> https://issues.apache.org/jira/browse/KAFKA-42
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1805: adding equals and hashcode methods to ProducerRecord.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
>
> Diff: https://reviews.apache.org/r/29468/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Parth Brahmbhatt
>
>
Re: Review Request 29468: Patch for KAFKA-1805
Posted by Parth Brahmbhatt <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29468/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 12:37 a.m.)
Review request for kafka.
Bugs: KAFKA-1805, KAFKA-1905 and KAFKA-42
https://issues.apache.org/jira/browse/KAFKA-1805
https://issues.apache.org/jira/browse/KAFKA-1905
https://issues.apache.org/jira/browse/KAFKA-42
Repository: kafka
Description
-------
KAFKA-1805: adding equals and hashcode methods to ProducerRecord.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 065d4e6c6a4966ac216e98696782e2714044df29
Diff: https://reviews.apache.org/r/29468/diff/
Testing
-------
Thanks,
Parth Brahmbhatt