You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/18 20:50:18 UTC
[GitHub] [arrow] alamb commented on a change in pull request #8708: ARROW-10647: [Rust] [Parquet] Port benchmarks from from parquet-rs to arrow repo
alamb commented on a change in pull request #8708:
URL: https://github.com/apache/arrow/pull/8708#discussion_r526411337
##########
File path: rust/parquet/benches/codec.rs
##########
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#![feature(test)]
+extern crate parquet;
+#[macro_use]
+extern crate lazy_static;
+extern crate test;
+use test::Bencher;
+
+use std::{env, fs::File};
+
+use parquet::{basic::Compression, compression::*, file::reader::*};
+
+// 10k rows written in page v2 with type:
+//
+// message test {
+// required binary binary_field,
+// required int32 int32_field,
+// required int64 int64_field,
+// required boolean boolean_field,
+// required float float_field,
+// required double double_field,
+// required fixed_len_byte_array(1024) flba_field,
+// required int96 int96_field
+// }
+//
+// filled with random values.
+const TEST_FILE: &str = "10k-v2.parquet";
Review comment:
I created https://github.com/apache/parquet-testing/pull/15 -- if/when that gets merged in, I'll update this PR to pick up a later version of parquet-testing and remove the binar from this PR as well.
##########
File path: rust/parquet/benches/codec.rs
##########
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#![feature(test)]
+extern crate parquet;
+#[macro_use]
+extern crate lazy_static;
+extern crate test;
+use test::Bencher;
+
+use std::{env, fs::File};
+
+use parquet::{basic::Compression, compression::*, file::reader::*};
+
+// 10k rows written in page v2 with type:
+//
+// message test {
+// required binary binary_field,
+// required int32 int32_field,
+// required int64 int64_field,
+// required boolean boolean_field,
+// required float float_field,
+// required double double_field,
+// required fixed_len_byte_array(1024) flba_field,
+// required int96 int96_field
+// }
+//
+// filled with random values.
+const TEST_FILE: &str = "10k-v2.parquet";
Review comment:
I created https://github.com/apache/parquet-testing/pull/15 -- if/when that gets merged in, I'll update this PR to pick up a later version of parquet-testing and remove the binary from this PR as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org