You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "PengZheng (via GitHub)" <gi...@apache.org> on 2023/12/12 11:37:26 UTC
[PR] Feature/509 remove avpr (celix)
PengZheng opened a new pull request, #697:
URL: https://github.com/apache/celix/pull/697
This PR performs the planned removal of avpr from libdfi, as mentioned in #509.
It will also close #158.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove avpr (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes commented on code in PR #697:
URL: https://github.com/apache/celix/pull/697#discussion_r1423965382
##########
libs/framework/src/bundle_archive.c:
##########
@@ -65,6 +66,7 @@ static celix_status_t celix_bundleArchive_storeBundleStateProperties(bundle_arch
celix_properties_t* bundleStateProperties = NULL;
bundleStateProperties = celix_properties_load(archive->savedBundleStatePropertiesPath);
if (bundleStateProperties == NULL) {
+ celix_framework_logTssErrors(archive->fw->logger, CELIX_LOG_LEVEL_DEBUG);
Review Comment:
Should this not be an CELIX_LOG_LEVEL_ERROR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove avpr (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on code in PR #697:
URL: https://github.com/apache/celix/pull/697#discussion_r1423988302
##########
libs/framework/src/bundle_archive.c:
##########
@@ -65,6 +66,7 @@ static celix_status_t celix_bundleArchive_storeBundleStateProperties(bundle_arch
celix_properties_t* bundleStateProperties = NULL;
bundleStateProperties = celix_properties_load(archive->savedBundleStatePropertiesPath);
if (bundleStateProperties == NULL) {
+ celix_framework_logTssErrors(archive->fw->logger, CELIX_LOG_LEVEL_DEBUG);
Review Comment:
Indeed, it should be an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove avpr (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #697:
URL: https://github.com/apache/celix/pull/697#issuecomment-1851878219
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/697?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`8956987`)](https://app.codecov.io/gh/apache/celix/commit/8956987f83ebae0de2bb602da8ef556e3c3d2e7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 83.47% compared to head [(`8b1d1ff`)](https://app.codecov.io/gh/apache/celix/pull/697?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 84.31%.
> :exclamation: Current head 8b1d1ff differs from pull request most recent head 4aae7b0. Consider uploading reports for the commit 4aae7b0 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/celix/pull/697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...te\_service\_admin\_dfi/src/import\_registration\_dfi.c](https://app.codecov.io/gh/apache/celix/pull/697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvcmVtb3RlX3NlcnZpY2VfYWRtaW5fZGZpL3NyYy9pbXBvcnRfcmVnaXN0cmF0aW9uX2RmaS5j) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/celix/pull/697?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 83.47% 84.31% +0.83%
==========================================
Files 254 248 -6
Lines 32988 31124 -1864
==========================================
- Hits 27538 26243 -1295
+ Misses 5450 4881 -569
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celix/pull/697?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove avpr (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng merged PR #697:
URL: https://github.com/apache/celix/pull/697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org