You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "dcapwell (via GitHub)" <gi...@apache.org> on 2023/02/02 18:02:31 UTC
[GitHub] [cassandra] dcapwell commented on a diff in pull request #2114: CASSANDRA-18204: CEP-15: (C*) Add git submodule for Accord
dcapwell commented on code in PR #2114:
URL: https://github.com/apache/cassandra/pull/2114#discussion_r1094890754
##########
build.xml:
##########
@@ -283,10 +286,20 @@
</fileset>
</path>
- <target name="_build-accord">
- <echo unless:set="env.ACCORD_LOCAL_DEV">building Accord, set ACCORD_LOCAL_DEV environment variable to skip</echo>
- <exec unless:set="env.ACCORD_LOCAL_DEV" executable=".build/include-accord.sh" dir="${basedir}" logError="true" failonerror="true" failifexecutionfails="true" />
- <echo if:set="env.ACCORD_LOCAL_DEV">ACCORD_LOCAL_DEV environment variable is set, skipping pull/install</echo>
+ <target name="_build-accord" depends="init">
+ <exec executable="${basedir}/accord/gradlew" dir="${basedir}/accord" logError="true" failonerror="true" failifexecutionfails="true">
+ <!-- Need to call clean as a version change with a jar that didn't have code changes will not procude a new jar with the new version... so need clean to make sure build is stable -->
+ <arg value="clean" />
+ <arg value="build" />
+ <arg value="install" />
+ <arg value="-x" />
+ <arg value="test" />
+ <arg value="-x" />
+ <arg value="rat" />
+ <arg value="-Paccord_group=org.apache.cassandra" />
+ <arg value="-Paccord_artifactId=cassandra-accord" />
Review Comment:
TODO should these be a ant property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org