Re: [PR] [SPARK-57737][SQL] Speed up date_trunc zone offset resolution with a per-task cache [spark]

["uros-b (via GitHub)" <gi...@apache.org>]

uros-b commented on PR #56848:
URL: https://github.com/apache/spark/pull/56848#issuecomment-5530701580

   The template still says “Does this PR introduce any user-facing change? No.” That is no longer true.
   
   6f2fd53 changes date_trunc for WEEK / MONTH / QUARTER / YEAR when the truncated midnight is repeated at a DST/LMT fall-back. Two timestamps in the same period that used to truncate to different instants now both get the earlier one. That is the intended SPARK-56769 regression fix, and it is user-facing (partition / GROUP BY keys).
   
   Please:
   
   - Flip that section to Yes and describe the overlap case (the Berlin 1916 / Havana 2015 / Tokyo 1888 examples already in the tests are enough).
   - Mention SPARK-57769 in the title, e.g. [SPARK-57737][SPARK-57769][SQL] ....
   - Treat [#56908](https://github.com/apache/spark/pull/56908) as superseded (config, default unchanged) so the two PRs do not land as contradictory defaults.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org