You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/07 17:48:37 UTC

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

amaliujia commented on a change in pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#discussion_r436386235



##########
File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java
##########
@@ -194,6 +250,81 @@ public static boolean isMergeJoinSupported(JoinRelType joinType) {
     return DeriveMode.BOTH;
   }
 
+  private List<Integer> immutableIntListToList(ImmutableIntList intList, int offset) {

Review comment:
       I will probably add more comments to these new methods to explain what they are doing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org