[jira] [Commented] (HADOOP-11105) MetricsSystemImpl could leak memory in registered callbacks

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139283#comment-14139283 ] 

Hadoop QA commented on HADOOP-11105:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12669766/HADOOP-11105.patch
  against trunk revision 485c96e.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4759//console

This message is automatically generated.

> MetricsSystemImpl could leak memory in registered callbacks
> -----------------------------------------------------------
>
>                 Key: HADOOP-11105
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11105
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>         Attachments: HADOOP-11105.patch, memory_leak_1.png, memory_leak_2.png
>
>
> In {{MetricsSystemImpl.register(final String name, final String description, final T sink)}} method, we will also add a callback function to the {{callbacks}} array list. However, upon unregistering, the callback function is not removed from the list in existing code. As a result, the memory allocated for the callback function could accumulate in the {{MetricsSystemImpl}} list. In one of our cluster, we have seen a case where there are about 874 MB memory retained by {{MetricsSystemImpl}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)