You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/27 22:34:00 UTC
[jira] [Commented] (CB-12961) cordova-plugin-file doesn't work on
browser platform with iOS devices
[ https://issues.apache.org/jira/browse/CB-12961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065593#comment-16065593 ]
ASF GitHub Bot commented on CB-12961:
-------------------------------------
GitHub user robertfromont opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/210
CB-12961
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
browser (on iOS only)
### What does this PR do?
Works around the fact that Safari on iOS doesn't support saving Blobs in indexedDB databases
### What testing has been done on this change?
Manual testing on the browser platform to ensure that
- it now works on iOS browsers
- it still works on Firefox and Chrome browsers
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
(sorry, unsure how I'd write an automated test for iOS browsers)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nzilbb/cordova-plugin-file CB-12961
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #210
----
commit 79ccf5470a6ab99a4037c91d10106247afa2005c
Author: Robert Fromont <ro...@fromont.net.nz>
Date: 2017-06-27T21:31:09Z
Get file plugin working on browser platform for iOS devices.
Safari on iOS doesn't support saving Blobs or objects with function attributes to indexedDB databases.
These changes ensure that MyFile objects don't have a Blob attribute, and don't have function attributes.
commit a071548707ddad6a7d90b425f25263485b2a419d
Author: Robert Fromont <ro...@fromont.net.nz>
Date: 2017-06-27T21:51:51Z
Revert "Get file plugin working on browser platform for iOS devices."
This reverts commit 79ccf5470a6ab99a4037c91d10106247afa2005c.
commit 6e7640ee702a074ae8aaadb36d9b918dc8a5f9d3
Author: Robert Fromont <ro...@fromont.net.nz>
Date: 2017-06-27T22:24:02Z
CB-12961 browser on iOS - Get "put" working on browser platform for iOS devices.
Safari (and Chrome) on iOS doesn't support saving Blobs or objects with function attributes to indexedDB databases.
These changes ensure that MyFile objects don't have a Blob attribute, and don't have function attributes.
----
> cordova-plugin-file doesn't work on browser platform with iOS devices
> ---------------------------------------------------------------------
>
> Key: CB-12961
> URL: https://issues.apache.org/jira/browse/CB-12961
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
> Environment: "browser" platform apps running in iOS browsers - Safari and Chrome
> Reporter: Robert Fromont
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> An error is returned when put is called on the indexedDB database, because apparently iOS on Safari doesn't support saving Blobs. It turns out it also doesn't appear to support saving objects with function attributes, including getters/setters.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org