You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/04/18 01:18:34 UTC
Review Request 20469: AURORA-178 - Log snapshot operations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Repository: aurora
Description
-------
AURORA-178 - Log snapshot operations
Testing Done:
./gradlew build
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11
Diff: https://reviews.apache.org/r/20469/diff/
Testing
-------
Thanks,
David McLaughlin
Re: Review Request 20469: AURORA-178 - Log snapshot operations
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/
-----------------------------------------------------------
(Updated April 25, 2014, 6:02 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs: AURORA-178
https://issues.apache.org/jira/browse/AURORA-178
Repository: aurora
Description
-------
AURORA-178 - Log snapshot operations
Testing Done:
./gradlew build
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11
Diff: https://reviews.apache.org/r/20469/diff/
Testing
-------
Thanks,
David McLaughlin
Re: Review Request 20469: AURORA-178 - Log snapshot operations
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/#review40773
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On April 18, 2014, 12:10 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20469/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 12:10 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-178
> https://issues.apache.org/jira/browse/AURORA-178
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-178 - Log snapshot operations
>
>
> Testing Done:
> ./gradlew build
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11
>
> Diff: https://reviews.apache.org/r/20469/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 20469: AURORA-178 - Log snapshot operations
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/#review41437
-----------------------------------------------------------
Dave - can you address Maxim's comment? I assume he will commit at that point.
- Bill Farner
On April 18, 2014, 12:10 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20469/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 12:10 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-178
> https://issues.apache.org/jira/browse/AURORA-178
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-178 - Log snapshot operations
>
>
> Testing Done:
> ./gradlew build
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11
>
> Diff: https://reviews.apache.org/r/20469/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 20469: AURORA-178 - Log snapshot operations
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/#review40815
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
<https://reviews.apache.org/r/20469/#comment73985>
s/host/ host
- Maxim Khutornenko
On April 18, 2014, 12:10 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20469/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 12:10 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Bugs: AURORA-178
> https://issues.apache.org/jira/browse/AURORA-178
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-178 - Log snapshot operations
>
>
> Testing Done:
> ./gradlew build
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11
>
> Diff: https://reviews.apache.org/r/20469/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 20469: AURORA-178 - Log snapshot operations
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/
-----------------------------------------------------------
(Updated April 18, 2014, 12:10 a.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs: AURORA-178
https://issues.apache.org/jira/browse/AURORA-178
Repository: aurora
Description
-------
AURORA-178 - Log snapshot operations
Testing Done:
./gradlew build
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11
Diff: https://reviews.apache.org/r/20469/diff/
Testing
-------
Thanks,
David McLaughlin
Re: Review Request 20469: AURORA-178 - Log snapshot operations
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/#review40717
-----------------------------------------------------------
Please note the bug in the review field as well.
- Bill Farner
On April 17, 2014, 11:18 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20469/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 11:18 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-178 - Log snapshot operations
>
>
> Testing Done:
> ./gradlew build
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11
>
> Diff: https://reviews.apache.org/r/20469/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 20469: AURORA-178 - Log snapshot operations
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20469/#review40716
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
<https://reviews.apache.org/r/20469/#comment73849>
You can just use LOG.info here.
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java
<https://reviews.apache.org/r/20469/#comment73850>
Consider logging info about number of tasks, number of jobs, etc in the snapshot that was created.
- Kevin Sweeney
On April 17, 2014, 4:18 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20469/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 4:18 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-178 - Log snapshot operations
>
>
> Testing Done:
> ./gradlew build
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11
>
> Diff: https://reviews.apache.org/r/20469/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David McLaughlin
>
>