You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nikdeapen (via GitHub)" <gi...@apache.org> on 2023/04/07 20:21:20 UTC
[GitHub] [iceberg] nikdeapen opened a new pull request, #7298: Bug Fix GCSInputStream Single Byte Read
nikdeapen opened a new pull request, #7298:
URL: https://github.com/apache/iceberg/pull/7298
The current implementation ignores EOF and will return EOF or invalid result when the byte is negative.
This is causing an issue where unexpected EOF is returned for the hadoop parquet file reader when reading parquet metadata: https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ConeyLiu commented on a diff in pull request #7298: Bug Fix GCSInputStream Single Byte Read
Posted by "ConeyLiu (via GitHub)" <gi...@apache.org>.
ConeyLiu commented on code in PR #7298:
URL: https://github.com/apache/iceberg/pull/7298#discussion_r1161567793
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSInputStream.java:
##########
@@ -113,11 +113,12 @@ public int read() throws IOException {
singleByteBuffer.position(0);
pos += 1;
- channel.read(singleByteBuffer);
+ if (channel.read(singleByteBuffer) == -1)
Review Comment:
Maybe add some UTs to cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nikdeapen closed pull request #7298: Bug Fix GCSInputStream Single Byte Read
Posted by "nikdeapen (via GitHub)" <gi...@apache.org>.
nikdeapen closed pull request #7298: Bug Fix GCSInputStream Single Byte Read
URL: https://github.com/apache/iceberg/pull/7298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org