You are viewing a plain text version of this content. The canonical link for it is here.

Posted to devnull@infra.apache.org by "juneau001 (GitHub)" <gi...@apache.org> on 2018/08/27 12:26:26 UTC

[GitHub] [incubator-netbeans] juneau001 opened pull request #802: [NETBEANS-1074] Module Review glassfish.javaee

- no external library
- checked Rat report: everything has been relicensed to Apache, as this commit changes header to java file that contained Oracle licensing
- skimmed through module, did not notice additional problems

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/802 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] junichi11 commented on issue #802: [NETBEANS-1074] Module Review glassfish.javaee

Posted by "junichi11 (GitHub)" <gi...@apache.org>.

Please add the licenseinfo.xml file if possible because there are some image files.
e.g. see https://github.com/apache/incubator-netbeans/blob/master/websvc.manager/licenseinfo.xml

Thanks.

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/802 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] juneau001 commented on issue #802: [NETBEANS-1074] Module Review glassfish.javaee

Posted by "juneau001 (GitHub)" <gi...@apache.org>.

Thanks for pointing me to that documentation.  I am going to close this pull request and re-do it using a branch.  I apologize for back and forth...I appreciate your time.

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/802 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] juneau001 closed pull request #802: [NETBEANS-1074] Module Review glassfish.javaee

Posted by "juneau001 (GitHub)" <gi...@apache.org>.

[ pull request closed by juneau001 ]

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/802 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] junichi11 commented on issue #802: [NETBEANS-1074] Module Review glassfish.javaee

Posted by "junichi11 (GitHub)" <gi...@apache.org>.

Thanks! 
Please remove `glassfish.javaee/external/binaries-list`.

BTW, you should not use the master branch. i.e. you should create a branch.
see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681408

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/802 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org