You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Robert Muir (Jira)" <ji...@apache.org> on 2020/07/17 03:05:00 UTC
[jira] [Commented] (LUCENE-9188) Add jacoco code coverage support
to gradle build
[ https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159638#comment-17159638 ]
Robert Muir commented on LUCENE-9188:
-------------------------------------
I still intend to get back and fix this patch up, sorry for the delays.
[~dweiss] to answer your question, I think even casually perusing these coverage reports on the existing code is useful. When you see chunks of untested code, there might be dragons. Here is one bug i found doing that (browsing a jenkins-generated report looking for trouble): LUCENE-2627
So it is a bit of a different use-case than when e.g. writing targeted test suite in your IDE?
[~sokolov]: +1 to the idea to find a way to generate these reports for code reviews in the future (somehow). IMO we want to minimize the bar for reviewing code: run automated tests and checks, provide basic analysis like this to the reviewer, etc.
> Add jacoco code coverage support to gradle build
> ------------------------------------------------
>
> Key: LUCENE-9188
> URL: https://issues.apache.org/jira/browse/LUCENE-9188
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
> Reporter: Robert Muir
> Priority: Major
> Attachments: LUCENE-9188.patch, report.png
>
>
> Seems to be missing. I looked into it a little, all the documented ways of using the jacoco plugin seem to involve black magic if you are using "java" plugin, but we are using "javaLibrary", so I wasn't able to hold it right.
> This one should work very well, it has low overhead and should work fine running tests in parallel (since it supports merging of coverage data files: that's how it works in the ant build)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org