You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ryabov Dmitrii (JIRA)" <ji...@apache.org> on 2017/12/11 10:08:01 UTC
[jira] [Comment Edited] (IGNITE-602) [Test] GridToStringBuilder is
vulnerable for StackOverflowError caused by infinite recursion
[ https://issues.apache.org/jira/browse/IGNITE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285702#comment-16285702 ]
Ryabov Dmitrii edited comment on IGNITE-602 at 12/11/17 10:07 AM:
------------------------------------------------------------------
[~agura], fixed. This test failed because of missing annotation {{@GridToStringExcelude}}. Now I write {{ByteBuffer}} s by their {{toString()}} as it's implementation returns only useful things (position, limit and capacity) without unnecessary phantom references like {{Cleaner}}.
[Now|https://ci.ignite.apache.org/viewLog.html?buildId=988843&tab=buildResultsDiv&buildTypeId=Ignite20Tests_RunAll] tests don't fail with StackOverflowError.
was (Author: somefire):
[~agura], fixed. This test failed because of missing annotation {{@GridToStringExcelude}}. Now I write {{ByteBuffer}} s by their {{toString()}} as it's implementation returns only useful things (position, limit and capacity) without unnecessary phantom references like {{Cleaner}}.
> [Test] GridToStringBuilder is vulnerable for StackOverflowError caused by infinite recursion
> --------------------------------------------------------------------------------------------
>
> Key: IGNITE-602
> URL: https://issues.apache.org/jira/browse/IGNITE-602
> Project: Ignite
> Issue Type: Bug
> Components: general
> Reporter: Artem Shutak
> Assignee: Ryabov Dmitrii
> Labels: MakeTeamcityGreenAgain, Muted_test
> Fix For: 2.4
>
>
> See test org.gridgain.grid.util.tostring.GridToStringBuilderSelfTest#_testToStringCheckAdvancedRecursionPrevention and related TODO in same source file.
> Also take a look at http://stackoverflow.com/questions/11300203/most-efficient-way-to-prevent-an-infinite-recursion-in-tostring
> Test should be unmuted on TC after fix.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)