You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/13 03:17:37 UTC

[GitHub] [skywalking] 457775987 opened a new issue #7915: [Bug] Adding agents affects spring AOP

457775987 opened a new issue #7915:
URL: https://github.com/apache/skywalking/issues/7915


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   Java Agent (apache/skywalking-java)
   
   ### What happened
   
   After I add an agent, a class defaultaopproxyfactory in spring AOP will have one more field by default. This class is a serialized class, resulting in a mismatch in the deserialization suid
   ![join-agent](https://user-images.githubusercontent.com/2177178/137060663-be4dcabe-40a3-45b7-a6d8-e6fd0dacaf2f.png)
   ![no-agent](https://user-images.githubusercontent.com/2177178/137060668-04500170-32f8-4e4c-9f48-366e84b5f927.png)
   
   
   ### What you expected to happen
   
    Adding agent does not affect the existing structure 。
   
   ### How to reproduce
   
   。。。
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942029024


   > Thank you. Can you release a version after modification, and then close the issue so that I can receive notifications
   
   Official release is controlled by the PMC, not me. So, I don't know when they call for release. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942390282


   >First question: the results of unit tests I use will be different every time serialVersionUID;
   
   Then this issue has nothing related to new field.
   
   > The second problem: there are indeed multiple applications. The single sign on system does not have an agent installed. It puts it into the cache and installs the agent's fetch cache
   
   This is unexpected case too. But, still, the serialVersionUID changing matters, it means, if you want to put this object into cache by using JdkSerializationRedisSerializer, it is nearly impossible. Maybe we could submit question to ByteBuddy project to ask whether there is a solution.
   
   But even it has, I prefer to ask you looking for solution in the Spring ecosystem. There should be a way to change serializer, mostly JSON or YAML serializer doesn't care about the `serialVersionUID`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941940921


    Sorry, it's translated in English by software. I want to explain that this defaultaopproxyfactory is saved by spring security after the user logs in. I didn't do this. When I request an address, it will be intercepted by spring security and go to redis to obtain the user information. Can it be solved only through spring security 。
   (抱歉,英文使用软件翻译的,我的意思想说明,这个DefaultAopProxyFactory是spring security在用户登录之后保存的,我没有做这个事情,当我请求一个地址的时候,会被spring security拦截,前往redis获取用户信息反序列化出现的,是不是只能通过spring security解决)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug]

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941876827


   All issues should have good title and reported in English.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug]

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941876827






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941895801


    At present, spring security should serialize this class to redis. We directly join skywalking through javaagent without other special operations. At present, because the additional field of agent affects suid calculation, we can only deal with spring security? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942328365


   First question: the results of unit tests I use will be different every time serialVersionUID;
   
   The second problem: there are indeed multiple applications. The single sign on system does not have an agent installed. It puts it into the cache and installs the agent's fetch cache
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng closed issue #7915: [Bug]

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7915:
URL: https://github.com/apache/skywalking/issues/7915


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941890973


   Then, the same question, why enhancing this class? We don't enhance this in default.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941882536


   > 
   > 
   > The question we want to ask is, why do you want to enhance a serializable class?
   
   This problem occurs because we have a single sign on and redis shared session, which are the default sequence mechanism for spring security operations
   
   deserialize payload. Is the byte array a result of corresponding serialization for DefaultDeserializer?; nested exception is java.io.InvalidClassException: org.springframework.aop.framework.DefaultAopProxyFactory; local class incompatible: stream classdesc serialVersionUID = 7930414337282325166, local class serialVersionUID = 7250238719487042907
   	at org.springframework.data.redis.serializer.JdkSerializationRedisSerializer.deserialize(JdkSerializationRedisSerializer.java:84)
   	at org.springframework.data.redis.core.AbstractOperations.deserializeHashValue(AbstractOperations.java:354)
   	at org.springframework.data.redis.core.AbstractOperations.deserializeHashMap(AbstractOperations.java:298)
   	at org.springframework.data.redis.core.DefaultHashOperations.entries(DefaultHashOperations.java:233)
   	at org.springframework.data.redis.core.DefaultBoundHashOperations.entries(DefaultBoundHashOperations.java:172)
   	at org.springframework.session.data.redis.RedisOperationsSessionRepository.getSession(RedisOperationsSessionRepository.java:466)
   	at org.springframework.session.data.redis.RedisOperationsSessionRepository.findById(RedisOperationsSessionRepository.java:435)
   	at org.springframework.session.data.redis.RedisOperationsSessionRepository.findById(RedisOperationsSessionRepository.java:247)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942003811


   ![aop](https://user-images.githubusercontent.com/2177178/137086520-8a7dce04-692f-4825-99dc-43d6de067058.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng closed issue #7915: [Bug]

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7915:
URL: https://github.com/apache/skywalking/issues/7915


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942859949


    I'm trying to change serialization to Jackson. Compared with jdkserializationredisserializer, I have encountered some problems. OAuth and spring security may need to do a lot of work, which has not been solved yet 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942004781


    This is generated by the spring security OAuth security framework .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng edited a comment on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941898463


   > At present, spring security should serialize this class to redis. 
   
   `DefaultAopProxyFactory` in serialization is the thing we don't know why, I think. 
   
   I did a quick search in the codes, `apm-spring-core-patch` plugin enhanced this, because there is conflicts happening between Spring internal mechanism and SkyWalking's agent.
   
   My question will be, why put this in the streaming? I think this is a code abuse?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942003582


   Through my efforts, I found that it was generated from the spring security oaurh2 protocol


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941943682


   We don't have mechanism to skip adding this field, because enhanced object in interceptor requires this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941900645


   `DefaultAopProxyFactory` has no field, just several methods, why do you put this in serialization process?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942028286


   Thank you. Can you release a version after modification, and then close the issue so that I can receive notifications


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942315136


   > stream classdesc serialVersionUID = 7930414337282325166, local class serialVersionUID = 7250238719487042907
   
   @457775987 I read this error again, it makes me feeling, a dynamic field is not the root cause. The instrumentation itself is.
   
   I am not sure when `serialVersionUID` gets changed, does rebooting make `local class serialVersionUID` changed every time?
   
   Also, another question is, does the same application(agent installed) put the AopProxyFactory into the cache? From my understanding, there is one JVM process without agent installed puts the class instance(AopProxyFactory) into the cache, and another JVM process with agent installed read it out, or vice versa. Then, this class structure mismatching happens.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-942011436


   OK, I may add something enhancing this later. But, generally, Spring should not do like this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-944891672


   After many attempts, there are many problems with JSON serialization and its support is not very good. The current solution is to add the skywalking agent system to declare that defaultaopproxyfactory overrides the one provided by spring AOP, and declare a fixed private static final long serialVersionUID = 7930414337282325166l;
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng edited a comment on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941898463


   > At present, spring security should serialize this class to redis. 
   
   `DefaultAopProxyFactory` in serialization is the thing we don't know why, I think. 
   
   I did a quick search in the codes, `apm-spring-core-patch` plugin enhanced this, because there is conflicts happening between Spring internal mechanism and SkyWalking's agent.
   
   My question will be, why put this in the streaming? I think this is a code abuse?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941879229


   The question we want to ask is, why do you want to enhance a serializable class?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941882536






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941974516


   > deserialize payload. Is the byte array a result of corresponding serialization for DefaultDeserializer?; nested exception is java.io.InvalidClassException: org.springframework.aop.framework.DefaultAopProxyFactory; local class incompatible: stream classdesc serialVersionUID = 7930414337282325166, local class serialVersionUID = 7250238719487042907
   at org.springframework.data.redis.serializer.JdkSerializationRedisSerializer.deserialize(JdkSerializationRedisSerializer.java:84)
   at org.springframework.data.redis.core.AbstractOperations.deserializeHashValue(AbstractOperations.java:354)
   at org.springframework.data.redis.core.AbstractOperations.deserializeHashMap(AbstractOperations.java:298)
   at org.springframework.data.redis.core.DefaultHashOperations.entries(DefaultHashOperations.java:233)
   at org.springframework.data.redis.core.DefaultBoundHashOperations.entries(DefaultBoundHashOperations.java:172)
   at org.springframework.session.data.redis.RedisOperationsSessionRepository.getSession(RedisOperationsSessionRepository.java:466)
   at org.springframework.session.data.redis.RedisOperationsSessionRepository.findById(RedisOperationsSessionRepository.java:435)
   at org.springframework.session.data.redis.RedisOperationsSessionRepository.findById(RedisOperationsSessionRepository.java:247)
   
   Could you check you codes? Which object is being used in this Redis Cache? This should be the root cause.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941944376


   I could consider adding a weak instrumentation for this, but we don't have it for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941879055


   Yes, this field is planned to be added, and a lot of plugins require this field to provide high performance. That is one of many reasons of SkyWalking agent having such good performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] 457775987 closed issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
457775987 closed issue #7915:
URL: https://github.com/apache/skywalking/issues/7915


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941897157


   I don't understand what you are saying. You could an object into Redis or Spring or anything, SkyWalking don't manipulate it in default. SkyWalking is targeting specific classes for tracing only. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #7915: [Bug] Adding agents affects spring AOP

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7915:
URL: https://github.com/apache/skywalking/issues/7915#issuecomment-941898463


   > At present, spring security should serialize this class to redis. 
   
   `DefaultOapProxyFactory` in serialization is the thing we don't know why, I think. 
   I did a quick search in the codes, we don't instrument `DefaultOapProxyFactory` class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org