[GitHub] [airflow] pankajkoti commented on a diff in pull request #26357: Require dag_id arg for dags list-runs and list-jobs

[GitBox <gi...@apache.org>]

pankajkoti commented on code in PR #26357:
URL: https://github.com/apache/airflow/pull/26357#discussion_r969249816


##########
airflow/cli/cli_parser.py:
##########
@@ -245,6 +245,9 @@ def string_lower_type(val):
     choices={ColorMode.ON, ColorMode.OFF, ColorMode.AUTO},
     default=ColorMode.AUTO,
 )
+ARG_DAG_ID_REQ_FLAG = Arg(
+    ("-d", "--dag-id"), required=True, help="The id of the dag"

Review Comment:
   ```suggestion
       ("-d", "--dag-id"), required=True, help="The ID of the dag"
   ```



##########
airflow/cli/cli_parser.py:
##########
@@ -245,6 +245,9 @@ def string_lower_type(val):
     choices={ColorMode.ON, ColorMode.OFF, ColorMode.AUTO},
     default=ColorMode.AUTO,
 )
+ARG_DAG_ID_REQ_FLAG = Arg(

Review Comment:
   Can we not keep just `ARG_DAG_ID` ? Do we need the suffix `REQ_FLAG` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org