You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/04/27 12:15:26 UTC

[GitHub] [accumulo] milleruntime commented on pull request #1596: Create public API for loading iterators. Closes #1388

milleruntime commented on pull request #1596:
URL: https://github.com/apache/accumulo/pull/1596#issuecomment-619947819


   > What is the clear and overwhelming value to end users for having this in the public API?
   
   Short answer is... I am not convinced there is overwhelming value.  
   
   I discovered that Datawave was using the method when it was a part of IteratorUtil (which I recently refactored since it used internal types).  That can be seen [here](https://github.com/NationalSecurityAgency/datawave/blob/master/warehouse/query-core/src/main/java/datawave/mr/bulk/RecordIterator.java#L390).  It seems to me this is either legacy use of internal code when there were no other options in the API or it is a more advanced use case of iterators, where there is need to load the iterators programmatically on the fly. I don't know enough about how it is used to know more.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org