You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2010/05/03 20:02:06 UTC
[jira] Created: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
adding some java doc to Server.RpcMetrics, UGI
----------------------------------------------
Key: HADOOP-6745
URL: https://issues.apache.org/jira/browse/HADOOP-6745
Project: Hadoop Common
Issue Type: Improvement
Reporter: Boris Shkolnik
Priority: Minor
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864091#action_12864091 ]
Jitendra Nath Pandey commented on HADOOP-6745:
----------------------------------------------
@return should be added for getRpcMetrics javadoc.
+1 otherwise
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-6745-BP20-1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik reassigned HADOOP-6745:
--------------------------------------
Assignee: Boris Shkolnik
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6745:
-----------------------------------------
Status: Patch Available (was: Open)
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-6745-BP20-1.patch, HADOOP-6745-BP20-2.patch, HADOOP-6745.1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6745:
-----------------------------------------
Attachment: HADOOP-6745.1.patch
Patch for trunk.
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-6745-BP20-1.patch, HADOOP-6745-BP20-2.patch, HADOOP-6745.1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6745:
-----------------------------------
Attachment: HADOOP-6745-BP20-2.patch
addressed Jitendra's comment.
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-6745-BP20-1.patch, HADOOP-6745-BP20-2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6745:
--------------------------------
Affects Version/s: 0.22.0
Component/s: ipc
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6745-BP20-1.patch, HADOOP-6745-BP20-2.patch, HADOOP-6745.1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892988#action_12892988 ]
Hadoop QA commented on HADOOP-6745:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12450644/HADOOP-6745.1.patch
against trunk revision 979785.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/console
This message is automatically generated.
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-6745-BP20-1.patch, HADOOP-6745-BP20-2.patch, HADOOP-6745.1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6745:
--------------------------------
Hadoop Flags: [Reviewed]
+1
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-6745-BP20-1.patch, HADOOP-6745-BP20-2.patch, HADOOP-6745.1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-6745:
--------------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: 0.22.0
Resolution: Fixed
I've committed this. Thanks Jitendra and Boris. Resolving as fixed.
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-6745-BP20-1.patch, HADOOP-6745-BP20-2.patch, HADOOP-6745.1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893007#action_12893007 ]
Jitendra Nath Pandey commented on HADOOP-6745:
----------------------------------------------
The javadoc warnings are in KerberosName.java and SecurityUtil.java which are related to kerberos API and are unrelated to this patch.
No tests included because this patch changes only javadocs.
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-6745-BP20-1.patch, HADOOP-6745-BP20-2.patch, HADOOP-6745.1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6745) adding some java doc to
Server.RpcMetrics, UGI
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6745:
-----------------------------------
Attachment: HADOOP-6745-BP20-1.patch
previous version, not for commit
> adding some java doc to Server.RpcMetrics, UGI
> ----------------------------------------------
>
> Key: HADOOP-6745
> URL: https://issues.apache.org/jira/browse/HADOOP-6745
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-6745-BP20-1.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.