You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tony810430 <gi...@git.apache.org> on 2017/09/17 07:51:35 UTC

[GitHub] flink pull request #4678: [FLINK-7630] Allow passing a File or an InputStrea...

GitHub user tony810430 opened a pull request:

    https://github.com/apache/flink/pull/4678

    [FLINK-7630] Allow passing a File or an InputStream to ParameterTool.fromPropertiesFile()

    - Add two version with different parameter type for `ParameterTool.fromPropertiesFile()` method
    - Update unit test `ParameterToolTest.testFromPropertiesFile()`
    - Update best practice document to introduce these two ways to use `Parameter`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tony810430/flink FLINK-7630

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4678.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4678
    
----
commit fa16ddd3e46112e0a96d6da6a1172e528aa1cb36
Author: Tony Wei <to...@gmail.com>
Date:   2017-09-17T05:45:02Z

    [FLINK-7630] Allow passing a File or an InputStream to ParameterTool.fromPropertiesFile()

----


---

[GitHub] flink issue #4678: [FLINK-7630] [Java API] Allow passing a File or an InputS...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4678
  
    The changes look good! 👍 I especially like the added tests and documentation.


---

[GitHub] flink issue #4678: [FLINK-7630] [Java API] Allow passing a File or an InputS...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4678
  
    I merged, could you please close this PR?
    
    And thanks for working on this! 😃 


---

[GitHub] flink issue #4678: [FLINK-7630] [Java API] Allow passing a File or an InputS...

Posted by tony810430 <gi...@git.apache.org>.

Github user tony810430 commented on the issue:

    https://github.com/apache/flink/pull/4678
  
    I thought it would be closed automatically. But it's okay, I will close it. Thanks for your quick review.


---

[GitHub] flink pull request #4678: [FLINK-7630] [Java API] Allow passing a File or an...

Posted by tony810430 <gi...@git.apache.org>.

Github user tony810430 closed the pull request at:

    https://github.com/apache/flink/pull/4678


---