You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/03/23 14:45:32 UTC
[PR] [MGPG-113] SignAndDeployFileMojo results in 401 [maven-gpg-plugin]
cstamas opened a new pull request, #82:
URL: https://github.com/apache/maven-gpg-plugin/pull/82
The RemoteRepository was "bare", it has to be equipped with AuthenticationSelector to be able to perform authenticated deploys.
Also, a bit of tidy up, layout is deprecated in Maven3 and is unused.
---
https://issues.apache.org/jira/browse/MGPG-113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MGPG-113] SignAndDeployFileMojo results in 401 [maven-gpg-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #82:
URL: https://github.com/apache/maven-gpg-plugin/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MGPG-113] SignAndDeployFileMojo results in 401 [maven-gpg-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #82:
URL: https://github.com/apache/maven-gpg-plugin/pull/82#discussion_r1536676449
##########
src/main/java/org/apache/maven/plugins/gpg/SignAndDeployFileMojo.java:
##########
@@ -149,7 +143,10 @@ public class SignAndDeployFileMojo extends AbstractGpgMojo {
/**
* The type of remote repository layout to deploy to. Try <i>legacy</i> for a Maven 1.x-style repository layout.
+ *
+ * @deprecated Maven3 does not support "legacy" (Maven1) layout anymore. This parameter is unused.
*/
+ @Deprecated
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MGPG-113] SignAndDeployFileMojo results in 401 [maven-gpg-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #82:
URL: https://github.com/apache/maven-gpg-plugin/pull/82#discussion_r1536676045
##########
src/main/java/org/apache/maven/plugins/gpg/SignAndDeployFileMojo.java:
##########
@@ -149,7 +143,10 @@ public class SignAndDeployFileMojo extends AbstractGpgMojo {
/**
* The type of remote repository layout to deploy to. Try <i>legacy</i> for a Maven 1.x-style repository layout.
+ *
+ * @deprecated Maven3 does not support "legacy" (Maven1) layout anymore. This parameter is unused.
*/
+ @Deprecated
Review Comment:
I would like to remove such parameters.
With deprecated - we will have warning about it - the similar will be than we remove it and someone will use it - warning will be emitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org