You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/27 02:45:55 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #4217: Fix #4216 to make xml integration tests working in native build
zhfeng opened a new pull request, #4217:
URL: https://github.com/apache/camel-quarkus/pull/4217
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #4217: Fix #4216 to make xml integration tests working in native build
Posted by GitBox <gi...@apache.org>.
zhfeng merged PR #4217:
URL: https://github.com/apache/camel-quarkus/pull/4217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4217: Fix #4216 to make xml integration tests working in native build
Posted by GitBox <gi...@apache.org>.
zhfeng commented on code in PR #4217:
URL: https://github.com/apache/camel-quarkus/pull/4217#discussion_r1006805840
##########
extensions/xslt/deployment/src/main/java/org/apache/camel/quarkus/component/xslt/deployment/XsltProcessor.java:
##########
@@ -149,4 +150,10 @@ void xsltResources(
}
}
+ //It should be removed with fixing https://github.com/apache/camel-quarkus/issues/1615
+ @BuildStep
+ void runtimeInit(BuildProducer<RuntimeInitializedClassBuildItem> deps) {
+ deps.produce(new RuntimeInitializedClassBuildItem("org.apache.hc.client5.http.impl.auth.NTLMEngineImpl"));
Review Comment:
@essobedo Thanks for the suggestion and it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on a diff in pull request #4217: Fix #4216 to make xml integration tests working in native build
Posted by GitBox <gi...@apache.org>.
essobedo commented on code in PR #4217:
URL: https://github.com/apache/camel-quarkus/pull/4217#discussion_r1006512665
##########
extensions/xslt/deployment/src/main/java/org/apache/camel/quarkus/component/xslt/deployment/XsltProcessor.java:
##########
@@ -149,4 +150,10 @@ void xsltResources(
}
}
+ //It should be removed with fixing https://github.com/apache/camel-quarkus/issues/1615
+ @BuildStep
+ void runtimeInit(BuildProducer<RuntimeInitializedClassBuildItem> deps) {
+ deps.produce(new RuntimeInitializedClassBuildItem("org.apache.hc.client5.http.impl.auth.NTLMEngineImpl"));
Review Comment:
Please note that since you have only one `RuntimeInitializedClassBuildItem` to produce, you could omit the producer and just return your instance of `RuntimeInitializedClassBuildItem`, something like:
```suggestion
RuntimeInitializedClassBuildItem runtimeInit() {
return new RuntimeInitializedClassBuildItem("org.apache.hc.client5.http.impl.auth.NTLMEngineImpl");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org